Skip to content
代码片段 群组 项目
提交 30e18e61 编辑于 作者: Neil Wang's avatar Neil Wang 提交者: Neil Wang
浏览文件

refactor: #845 remove destinationHost in iterationIssues

上级 17d0d4c4
分支
未找到相关标签
无相关合并请求
......@@ -6,6 +6,7 @@ import 'package:jihu_gitlab_app/core/gradient_progress_indicator.dart';
import 'package:jihu_gitlab_app/core/iterable_extension.dart';
import 'package:jihu_gitlab_app/core/layout/adaptive.dart';
import 'package:jihu_gitlab_app/core/load_state.dart';
import 'package:jihu_gitlab_app/core/project_provider.dart';
import 'package:jihu_gitlab_app/core/widgets/http_fail_view.dart';
import 'package:jihu_gitlab_app/core/widgets/loading_view.dart';
import 'package:jihu_gitlab_app/core/widgets/tips_view.dart';
......@@ -54,7 +55,7 @@ class _IterationIssuesPageState extends State<IterationIssuesPage> {
backgroundColor: Colors.white,
body: Consumer<ConnectionProvider>(builder: (context, _, child) {
if (_model.loadState == LoadState.loadingState) return const LoadingView();
if (!ConnectionProvider.authorized && widget.arguments['destinationHost'] == null) return const UnauthorizedView();
if (!ConnectionProvider.authorized && ProjectProvider().specifiedHost == null) return const UnauthorizedView();
if (_model.loadState == LoadState.errorState) return HttpFailView(onRefresh: () => _onRefresh());
if (_model.isEmpty) return TipsView(icon: 'assets/images/no_item.svg', message: JiHuLocalizations.dictionary().noData, onRefresh: () => _onRefresh());
return buildView();
......@@ -171,7 +172,7 @@ class _IterationIssuesPageState extends State<IterationIssuesPage> {
isEmpty: () => _model.loadState == LoadState.successState && _model.isEmpty,
onRefresh: _modelRefresh(),
scrollable: false,
destinationHost: _model.destinationHost,
destinationHost: ProjectProvider().specifiedHost,
onListItemTap: (index) {
final issue = issues[index];
final params = <String, dynamic>{
......@@ -183,7 +184,7 @@ class _IterationIssuesPageState extends State<IterationIssuesPage> {
'pathWithNamespace': issue.project.pathWithNamespace,
'issue': issue,
'showLeading': true,
'destinationHost': _model.destinationHost,
'destinationHost': ProjectProvider().specifiedHost,
};
Navigator.of(context).pushNamed(IssueDetailsPage.routeName, arguments: params);
},
......
import 'package:jihu_gitlab_app/core/domain/issue.dart';
import 'package:jihu_gitlab_app/core/load_state.dart';
import 'package:jihu_gitlab_app/core/log_helper.dart';
import 'package:jihu_gitlab_app/core/project_provider.dart';
import 'package:jihu_gitlab_app/modules/issues/list/project_issues_fetcher.dart';
class IterationIssuesModel {
......@@ -15,7 +16,6 @@ class IterationIssuesModel {
void init(Map arguments) {
groupFullPath = arguments['fullPath'];
id = arguments['iterationId'];
destinationHost = arguments['destinationHost'];
_projectIssuesFetcher = ProjectIssuesFetcher();
}
......@@ -52,7 +52,7 @@ class IterationIssuesModel {
}
Future<List<Issue>> getIterationIssues() async {
return _projectIssuesFetcher.fetchIssues(destinationHost, () => iterationIssuesRequestBody("", groupFullPath, id, 100));
return _projectIssuesFetcher.fetchIssues(ProjectProvider().specifiedHost, () => iterationIssuesRequestBody("", groupFullPath, id, 100));
}
}
......
import 'package:jihu_gitlab_app/core/domain/issue.dart';
import 'package:jihu_gitlab_app/core/project_provider.dart';
import 'package:jihu_gitlab_app/modules/issues/list/group_issues_fetcher.dart';
import 'package:jihu_gitlab_app/modules/iteration/details/iteration_model.dart';
......@@ -8,7 +9,7 @@ class SubgroupIterationIssuesModel extends IterationIssuesModel {
@override
void init(Map arguments) {
super.init(arguments);
groupIssuesFetcher = GroupIssuesFetcher(destinationHost, groupFullPath);
groupIssuesFetcher = GroupIssuesFetcher(ProjectProvider().specifiedHost, groupFullPath);
}
@override
......
import 'package:flutter/material.dart';
import 'package:jihu_gitlab_app/core/project_provider.dart';
import 'package:jihu_gitlab_app/modules/iteration/details/iteration_model.dart';
import 'package:jihu_gitlab_app/modules/iteration/details/iteration_page.dart';
import 'package:jihu_gitlab_app/modules/iteration/details/subgroup_iteration_issues_model.dart';
......@@ -42,7 +41,6 @@ class _IterationListViewState extends State<IterationListView> {
'iterationId': widget.iterations[index].id,
'iteration': widget.iterations[index],
'title': widget.title,
'destinationHost': ProjectProvider().specifiedHost,
'source': widget.source,
});
},
......
0% 加载中 .
You are about to add 0 people to the discussion. Proceed with caution.
想要评论请 注册