Skip to content

Draft: Fix i18n of date string on pipeline charts

路志远请求将fix-i18n-on-pipelines-charts合并到main-jh

What does this MR do and why?

Page link: https://gitlab.com/gitlab-org/gitlab/-/pipelines/charts

The date string 19 Aug is compiled through constants CHART_DATE_FORMAT.

// file: app/assets/javascripts/projects/pipelines/charts/constants.js
export const CHART_DATE_FORMAT = 'dd mmm';

The order of month and day is fixed, which is not suitable for Chinese. In Chinese habit, the correct order is month-day instead of day-month.

So it is necessary to provide an extended way so that jh can use its own translation method.

Screenshots or screen recordings

Language Before After
English (Nothing changed)
Chinese )

Issue: #1726

cc JH EM @prajnamas

路志远 编辑于

合并请求报告