Skip to content

Fix: pipeline buy additional minutes link

Martin Tan请求将fix/buy-additional-minutes合并到main-jh

What does this MR do and why?

One of JH test case is broken by a new feature flag in this MR.

The "Buy additional minutes" link in this file pipelines_quota/_list.html.haml won't be rendered if feature is enabled, see the code at usage_quotas/index.html.haml

Proposal

This feature default value is false and it won't change the behavior for staging or production, but the test case is not passed due to feature flags are enabled by default for testing environment. Then, the fix should be switching this feature flag to false for this case to fix pipeline job.

  • set usage_quotas_pipelines_vue to false for this case.

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Martin Tan 编辑于

合并请求报告