Skip to content

Feature/password complexity settings

related to #694 (closed)

upstream MR

This MR should be only contribute to upstream, so the following description are copied from upstream

Pending by the backend implementation !82798

What does this MR do and why?

Adding password complexity configuration fields to the Sign-up restrictions on General Settings page. This MR only includes backend implementation, frontend part can be found in this MR !86852.

This MR also exposes the complexity settings to /api/v4/application/settings api.

Proposal

To make this feature available, the following changes should be applied to Application Settings

  • Push licensed feature password_complexity to general action to let frontend know whether it has this licensed feature
  • Add password complexity config fields to signup_form components, so we can update these settings on General Settings page.
  • Put regex and error message to Gon for frontend form validation in this MR
  • Expose complexity settings to api
  • Update api docs

Screenshots or screen recordings

How to set up and validate locally

  • Make sure that frontend MR is merged
  • Make sure that your instance has a Premium/Ultimate license installed
  • Goto http://YOUT_LOCAL_HOST/admin/application_settings/general
  • Click on the Expand button of Sign-up restrictions
  • You should see the password complexity config inputs

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Martin Tan 编辑于

合并请求报告