Skip to content

Feat: pass user external to the phone page

Martin Tan请求将pass-external-to-terms合并到main-jh

What does this MR do and why?

related to https://jihulab.com/gitlab-cn/gitlab/-/issues/3776

  • Pass user external value to frontend on the phone page.

Screenshots or screen recordings

Not external user external users && terms enforced terms not enforced
false true false

How to set up and validate locally

case #1

  1. with terms enforced
  2. login as root user
  3. goto phones page
  4. you should not see the terms checkbox

case #2

  1. with terms enforced
  2. Oauth login
  3. goto phones page
  4. you should see the terms checkbox

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Martin Tan 编辑于

合并请求报告