Skip to content

Draft: Enforce acceptance of changed terms

Martin Tan请求将enforce-acceptance-of-changed-terms合并到main-jh

What does this MR do and why?

related to https://jihulab.com/gitlab-cn/gitlab/-/issues/3697

related to upstream issue https://gitlab.com/gitlab-org/gitlab/-/issues/345524

related upstream MR https://gitlab.com/gitlab-org/gitlab/-/merge_requests/136039

What's been done

  1. User must accept the latest version of terms, or they will be redirected to the terms page
  2. The redirection of terms is placed before the onboarding process
  3. License tier: Ultimate

Screenshots or screen recordings

terms

How to set up and validate locally

  1. In rails console enable the experiment fully
    Feature.enable(:enforce_acceptance_of_changed_terms)
  2. Login as admin
  3. Setup Terms of Service and Privacy Policy on http://127.0.0.1:3000/admin/application_settings/general
  4. Register a new user
  5. Login as that new user
  6. You should be redirected to the Terms Page

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Martin Tan 编辑于

合并请求报告

加载中