Skip to content

Hide `Pages` in settings panle

Yongbo li请求将hide_access_control_panel合并到main-jh

What does this MR do and why?

Hide Pages row in settings panel if disable public access in saas
Relates to: https://jihulab.com/gitlab-cn/gitlab/-/issues/1222#note_2272967

Screenshots or screen recordings

before after
image image

How to set up and validate locally

  1. install pages by
gdk install gitlab-pages
  1. enable pages
  2. enable access control
  3. disable public access
  4. simulate saas
  5. create a project and click Settings > General > Visibility, project features, permissions and search Pages

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Yongbo li 编辑于

合并请求报告

加载中