Skip to content

Add unit test of skiped_spec of upstream

Tom请求将qa/add-feature-flag-spec合并到main-jh

What does this MR do and why?

What: Add unit test of skiped_spec of QA of upstream.
Why: We skipped some must-fail specs, we need to cover them with our specs(qa-internal-jh)

Describe in detail what your merge request does and why.

Screenshots or screen recordings

The failed case

rspec ./spec/specs/helpers/context_selector_spec.rb:45 # QA::Specs::Helpers::ContextSelector.context_matches? with arguments matches multiple subdomains
rspec ./spec/specs/helpers/context_selector_spec.rb:60 # QA::Specs::Helpers::ContextSelector.context_matches? with arguments matches domain
rspec ./spec/specs/helpers/context_selector_spec.rb:54 # QA::Specs::Helpers::ContextSelector.context_matches? with arguments matches :production
rspec ./spec/specs/helpers/context_selector_spec.rb:232 # QA::Specs::Helpers::ContextSelector production runs on production
rspec ./spec/specs/helpers/context_selector_spec.rb:247 # QA::Specs::Helpers::ContextSelector production when excluding contexts skips production
rspec './spec/specs/helpers/feature_flag_spec.rb[1:1:2:2:1]' # QA::Specs::Helpers::FeatureFlag.skip_or_run_feature_flag_tests_or_contexts when run on production behaves like skips with given feature flag metadata is expected to eq :pending
rspec ./spec/specs/helpers/feature_flag_spec.rb:133 # QA::Specs::Helpers::FeatureFlag.skip_or_run_feature_flag_tests_or_contexts when run on production when no scope is defined for only one test in the example group only skips specified test and runs all others
rspec './spec/specs/helpers/feature_flag_spec.rb[1:1:2:1:1:1]' # QA::Specs::Helpers::FeatureFlag.skip_or_run_feature_flag_tests_or_contexts when run on production when no scope is defined behaves like skips with given feature flag metadata is expected to eq :pending

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Tom 编辑于

合并请求报告