Make JH Gitlab purchase from CustomerDot only
Hi, @godfat-gitlab @csouthard
Background
Gitlab already migrated a lot of purchase flows to the SaaS instance. we think if we doing the same thing, the effort is big for us. so we want to let the user redirect to CustomerDot, and finish the purchase flow on customerDot only. And one day, when you guys migrated everything to SaaS, we may synchronize with you guys.
Proposal
I read the code, I think we just overwrite that method in JH module. and let it always return false.
https://gitlab.com/gitlab-jh/gitlab/-/blob/main-jh/ee/app/helpers/billing_plans_helper.rb#L53-59
# currently
def use_new_purchase_flow?(namespace)
# new flow requires the user to already have a last name.
# This can be removed once https://gitlab.com/gitlab-org/gitlab/-/issues/298715 is complete.
return false unless current_user.last_name.present?
namespace.group? && (namespace.actual_plan_name == Plan::FREE || namespace.trial_active?)
end
# jh
def use_new_purchase_flow?(namespace)
false
end
Please help to check if it's OK