Job `only-jh-check` make sure not change anthing outside `jh`

Job #1370056387 failed for a548d99a:

The only-jh-check failed, but I am not clear how to see any error messages here, can you help see this? @godfat-gitlab

Executing "step_script" stage of the job script
00:01
Using docker image sha256:9b06bf3dd0ab8d484e8c9e9c611f75eab098939f568d587a7fd23a3c96eceb87 for registry.gitlab.com/gitlab-org/gitlab-build-images:ruby-2.7.2.patched-golang-1.14-git-2.31-lfs-2.9-chrome-89-node-14.15-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images@sha256:eb4fdeb3196481dd022d7d166468834e40a046b46a29e3349fb3bf3657176290 ...
$ git fetch origin ${CI_DEFAULT_BRANCH}
From https://gitlab.com/gitlab-jh/gitlab
 * branch                main-jh    -> FETCH_HEAD
 * [new branch]          main-jh    -> origin/main-jh
$ git diff --name-only origin/${CI_DEFAULT_BRANCH}... -- jh > jh-changes
$ git diff --name-only origin/${CI_DEFAULT_BRANCH}... > all-changes
$ diff jh-changes all-changes
0a1
> config/application.rb
5a7
> spec/helpers/emails_helper_spec.rb
Cleaning up file based variables
00:01
ERROR: Job failed: exit code 1

assigned to @memorycancel and @godfat-gitlab

By Zhu Shung on 2021-06-23T09:31:36 (imported from GitLab)

@memorycancel You can see that you have changes in those files:

• config/application.rb
• spec/helpers/emails_helper_spec.rb

This job is there to make sure you don't change any files outside of jh/. You can ignore it before you're ready to remove those changes, but before merging the merge requests, those changes should be discarded.

By Lin Jen-Shin on 2021-06-23T14:19:26 (imported from GitLab)

unassigned @godfat-gitlab

By Lin Jen-Shin on 2021-06-23T14:19:27 (imported from GitLab)

Actually, we should probably add a message explaining that.

By Lin Jen-Shin on 2021-06-23T14:44:15 (imported from GitLab)

@godfat-gitlab Thanks, I see. Can change this status icon from to ?

By Zhu Shung on 2021-06-23T14:44:15 (imported from GitLab)

@memorycancel No, otherwise we'll miss it.

Here's the merge request to improve the message: https://gitlab.com/gitlab-jh/gitlab/-/merge_requests/37

By Lin Jen-Shin on 2021-06-23T14:50:26 (imported from GitLab)

@godfat-gitlab I see, looks good to me.

By Zhu Shung on 2021-06-23T14:52:43 (imported from GitLab)

mentioned in merge request !37 (merged)

By Lin Jen-Shin on 2021-06-23T14:33:11 (imported from GitLab)

changed title from Job Failed #1370056387 to Job {+only-jh-check make sure not change anthing outside jh+}

By Zhu Shung on 2021-06-23T14:57:23 (imported from GitLab)