Stan Hu 创作于 1 year ago ，Lin Jen-Shin 提交于 1 year ago

This commit fixes two types of Rubocop failures seen only with Ruby 3.2:

* Style/ArgumentsForwarding: As explained in
  https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Style/ArgumentsForwarding,
  in Ruby 3.2, anonymous args/kwargs forwarding has been added. This cop can
  be disabled by setting `UseAnonymousForwarding: false`.

* Lint/RedundantRequireStatement: As explained in
  https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Lint/RedundantRequireStatement,
  `require 'set'` is no longer needed in Ruby 3.2. But since we still
  need to support Ruby 3.1 and earlier, disable this cop on `require 'set'`
  lines.

Relates to
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/140815#note_1712305597

Because those 2 tests will look up all the templates in the directory.

This script attempts to detect unused helper methods.

Signed-off-by: Rémy Coutable <remy@rymai.me>

Signed-off-by: Rémy Coutable <remy@rymai.me>

Replaces rails generator for supporting engineers
in creating internal events, metrics, and instrumenting
app code.

Signed-off-by: Rémy Coutable <remy@rymai.me>

Pre-16.3 migration files were removed and schema
changes moved to db/init_structure.sql file

Changelog: changed

This way `spec/models/every_model_spec.rb` is run in "fast fail" job(s)
whenever a model changes.

Additional rule fix

This ensures that for each new added gem, we claim the name of the gem.

This should help us understand job timeouts
in more detail.

Addressing: https://gitlab.com/gitlab-org/gitlab/-/issues/429803
Changelog: fixed

Signed-off-by: Rémy Coutable <remy@rymai.me>

Changelog: added

Also improve clarify messeage posted to run e2e test pipeline

Relates to https://gitlab.com/gitlab-org/gitlab/-/issues/428704

Update with new spec test cases

Refactor regex and correct test spec

Stub env var in CI

- Use threaded network requests.

- Combine the existing QA rspecs into one now that
the tests can be quickly run in one rspec.

- Add a fast CI job for QA regression detection
  Introduce a canary, non-optional CI job for GitLab Duo Chat
that is fast and cheap to run.

Refactor

Add testing commit, will be removed

Removes testing commit

We noticed that the namespace could not be
deleted because the gitlab runner pod takes
too long to be deleted.

This commit ensures we kill the gitlab runner review-
apps container after 1min.

This reverts merge request !136411

Eulyeon Ko 创作于 1 year ago ，Jennifer Li 提交于 1 year ago

- Use threaded network requests.

- Combine the existing QA rspecs into one now that
the tests can be quickly run in one rspec.

- Add a fast CI job for QA regression detection
  Introduce a canary, non-optional CI job for GitLab Duo Chat
that is fast and cheap to run.

https://gitlab.com/gitlab-org/gitlab/-/jobs/5535361923 timed-out
at 15min, but the deletion was successful.

We can increase the timeout to 30min, to make sure
a slow but successful job won't timeout most of the time.

They were removed in
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/127588