In real usage if you call `ENV.fetch('NON_EXISTENT_KEY')` it will raise
a `KeyError`. But our previously implementation of of `stub_env` with
`nil` is causing it to return `nil` rather than raising an error. This
can cause us to write tests that don't match the actual production
behaviour. We might forget to rescue the exception in a certain place or
we also may not be able to write a test case for the expected behaviour.

```
irb(main):001> ENV.fetch('NON_EXISTENT_KEY')
(irb):1:in `fetch': key not found: "NON_EXISTENT_KEY" (KeyError)

irb(main):002> ENV['NON_EXISTENT_KEY'] = nil
=> nil

irb(main):003> ENV.fetch('NON_EXISTENT_KEY')
(irb):3:in `fetch': key not found: "NON_EXISTENT_KEY" (KeyError)
```

This moves two spec helpers into `gitlab-rspec`.

Signed-off-by: Rémy Coutable <remy@rymai.me>

Signed-off-by: Rémy Coutable <remy@rymai.me>

Signed-off-by: Rémy Coutable <remy@rymai.me>

Signed-off-by: Rémy Coutable <remy@rymai.me>

Rémy Coutable 创作于 1 year ago ，Lin Jen-Shin 提交于 1 year ago

Signed-off-by: Rémy Coutable <remy@rymai.me>

Revert !124615

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/124640



Merged-by: Stan Hu <stanhu@gmail.com>
Approved-by: Stan Hu <stanhu@gmail.com>
Co-authored-by: Nao Hashizume <nhashizume@gitlab.com>

This reverts merge request !124615

Signed-off-by: Rémy Coutable <remy@rymai.me>

The purpose of this Gem is to move all `Gitlab::Utils` code
into the Gem, and use this for all common functions that
are not monolith specific.

Signed-off-by: Rémy Coutable <remy@rymai.me>

The purpose of this Gem is to move all `Gitlab::Utils` code
into the Gem, and use this for all common functions that
are not monolith specific.

Signed-off-by: Rémy Coutable <remy@rymai.me>

This gem is supposed to contain all source
code required to configure GitLab specific
rspec environment.

Changelog: added