We allow `add_column` and `create_table` methods inside the `down`
method in post-deploy migrations. But if these methods were wrapped
inside a statement like `if` then the cop was raising an error.
For example, in the following, the 2nd example was being incorrectly
flagged as an offense:

```
def down
  add_column(:table, :column)
end
```

```
def down
  add_column(:table, :column) unless column_exists(:table, :column)
end
```

Use Pathname API as much as possible and resolve all RuboCop offenses.

If specs change in {,ee/}/spec/migrations/**/*_spec.rb change RuboCop's
cache should be invalidated for this cop to avoid flaky results in CI.

Also, use RESTRICT_ON_SEND to define target method which is used by RuboCop
internally to speed-up scans.

Adds database migration and model definitions necessary to add
visibility toggle for Model experiments

Changelog: added

Previously, this cop only flagged `self.ignored_columns += [...]`.

Because of this change the cop rule is put back in "grace period" to
maintain `master` stability.

Flag local assignments during factory "load time". This leads to
static data definitions.

Move these definitions into attribute block or
`transient` block to ensure that the data is evaluated during
"runtime" and remains dynamic.

Example:
  # bad
  factory :foo do
    random = rand(23)
    baz { "baz-#{random}" }

    trait :a_trait do
      random = rand(23)
      baz { "baz-#{random}" }
    end

    transient do
      random = rand(23)
      baz { "baz-#{random}" }
    end
  end

  # good
  factory :foo do
    baz { "baz-#{random}" }

    trait :a_trait do
      baz { "baz-#{random}" }
    end

    transient do
      random { rand(23) }
    end
  end

Current offenses are excludes via
  rake rubocop:todo:generate[Graphql/ResourceNotAvailableError]

Put this cop in grace period.

Show the full source code in the offense message instead of its AST.

This same functionality is now covered by Gettext/StaticString.

This cop ensures that only static strings are passed to gettext
translation methods `_()`, `s_()`, `n_()`, `N_()`.

Any kind of interpolation, formatting, or concatenation is disallowed.

The following definitions are allowed:
* Local variables
* Method calls which are not mentioned above
* Constants

Generate TODOs for pending offenses in Ruby code.

This primarily targets ActionMailer::MailDeliveryJob which our mailers
send to Sidekiq. The ActiveJob wrapper does not include
ApplicationWorker which makes it tricky to configure `data_consistency`.

This MR introduces another path of logic to handle active jobs and
enable db load balancing for those jobs.

Changelog: other

Changelog: added
EE: true

An `authorize` statement with no arguments is the same as not having an
authorize statement at all. So, we should flag an offense if `authorize`
does not have any arugments.

Also:

- Moves geo database docs to ee/db/geo/docs/
- Adds support for embedding database docs in ee/db/embedding/docs/

Relates to https://gitlab.com/gitlab-org/gitlab/-/issues/404396

This MR removes usage of old method from the codebase.
Also removed corresponding rubocop check

- ensure good practice to try and leverage the non
  primary database

Changelog: removed

Short-hand Hash syntax does not work prior 3.1.

MR: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/110743

Changelog: other

This commit also fixes all offenses in changed files (except for
`usage_data.rb` which got too huge).

In Rails 7.0, `attribute` definitions in models now run at class
definition time, and calls model.connection_db_config. This means
swapping the connection_handler now breaks because there's no valid
connection_pool within with_disabled_database_connections block.

On investigation, `.connection_pool`, and `.connection_db_config` does
not create a database connection (model.connection does).

In order to have this keep working in Rails 7.0, we switch to counting
the number of connections before, and after instead. Also to prevent
re-use of connections, we also disconnect all active connections first.

Changelog: other

Only inspect example groups and examples for `feature_category:` and
skip normal test code.

Follow-up of
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/98669.

To avoid failing RuboCop CI jobs for Ruby 2.7 we are now enabling these
rules in Ruby 3.0 and disable them in Ruby 2.7. The opposite what we've
done previously.

Both cops are put in "grace period" so don't fail in CI on `master`.

Define a single node pattern to catch both cases `type: File` and
`types: [File, ...]`.

Defining node patterns on the fly is slow and discouraged.

Alina Mihaila 创作于 2 years ago ，Jennifer Li 提交于 2 years ago

  - For features that support developers and
  they are not specific to a product group

Add a cop to deny the use of disable_ddl_transaction!
when only validate_foreign_key is used, as PostgreSQL will add and
implicit transaction for single statements anyway.