Contributes to https://gitlab.com/gitlab-org/gitlab/-/issues/494689

**Problem**

We are going to add a not null constraint for snippet fields project_id
and organization_id. This change breaks test factories that generate
invalid records without any of these fields.

**Solution**

Update test suite to use a specific snippet type (Project or Personal)
instead of a generic `snippet`.

Pure specs refactoring

Archived projects can be included by specifying incluce_archived=true in params

Changelog: changed

This fixes services spec files

This change adds the ability to sort search results by Last Updated

During the testing of the original MR on staging we noticed that
sort doesn't work for all scopes. Turns out that we forgot to pass
sort parameter to some classes.
This MR fixes this problem and adds specs to catch similar type of
errors in the future.

The plan for RSpec 4.0 is to disable monkey patching, reference:
https://rspec.info/blog/2013/07/the-plan-for-rspec-3/#zero-monkey-patching-mode
https://relishapp.com/rspec/rspec-core/docs/configuration/zero-monkey-patching-mode

This commit stops using RSpec monkey patching in several specs.

Content and file name searching is no longer viable
with Snippets due to the values being within the
new snippet repositories

Ran: bundle exec rubocop --only RSpec/EmptyLineAfterFinalLet -a \
	spec/services/ spec/lib/

Probably useful as we often move these files to "new" files.

Merge branch 'security-10-4-25223-snippets-finder-doesnt-obey-feature-visibility' into 'security-10-4'

[Port for security-10-4]: Makes SnippetFinder ensure feature visibility

Merge branch 'security-10-4-25223-snippets-finder-doesnt-obey-feature-visibility' into 'security-10-4'

[Port for security-10-4]: Makes SnippetFinder ensure feature visibility

Signed-off-by: Rémy Coutable <remy@rymai.me>

Remove superfluous lib: true, type: redis, service: true, models: true, services: true, no_db: true, api: true

Signed-off-by: Rémy Coutable <remy@rymai.me>

Signed-off-by: Rémy Coutable <remy@rymai.me>

Signed-off-by: Rémy Coutable <remy@rymai.me>

Use the EnforcedStyleForMultiline: no_comma option.

Signed-off-by: Rémy Coutable <remy@rymai.me>