Skip to content
代码片段 群组 项目
该项目从 https://gitlab.com/gitlab-org/gitlab.git 镜像。 拉取镜像更新于
  1. 4月 13, 2023
  2. 4月 11, 2023
  3. 4月 08, 2023
  4. 4月 07, 2023
  5. 4月 06, 2023
  6. 4月 04, 2023
    • Lukas 'Eipi' Eipert's avatar
      Faster gettext extractor · 9d3f4829
      Lukas 'Eipi' Eipert 创作于
      The rake task `gettext:regenerate` takes around 50 seconds on my machine
      to extract _all_ externalized strings from ruby, haml, erb, js and vue
      sources. It is implemented in a blocking way and therefore parsing
      roughly 20000 files takes a long time.
      
      We are introducing a new tooling script `tooling/bin/gettext_extractor`
      which is 3x faster by making the following improvements:
      
      1. We parallelize the extraction of ruby, haml and erb with the
         `parallel` gem.
      2. Instead of passing files through a parser stack and checking which
         files a parser can parse, we directly call the parser for each file
         type. The original implementation e.g. checked for every file,
         whether it is a glade file (whatever that is), which took a long
         time.
      3. js and vue files are still parsed by a shell-out to the pre-existing
         node script: `scripts/frontend/extract_gettext_all.js`
      
      This new parser is now used under the hood for the rake tasks:
      `gettext:regenerate` and `gettext:update_check`.
      
      There is still room for improvement, and we should look into the
      following ideas:
      
      1. We currently scan `ee/spec`, which probably should not scan. We still
         scan it for now, in order to have parity in results
      2. The shell-out to node can be changed to stream the data, rather than
         blocking until all frontend files are scanned. However initial tests
         have not shown any performance improvements from that.
      3. The `HamlParser` probably could use `GetText::RubyParser` instead of
         `RubyGettextExtractor` under the hood.
      4. We likely can improve parsing performance _a lot_ by adding guard
         checks to see whether a file actually contains the literal names of
         the gettext methods, e.g. `_(`, `n_(` or `N_(`). We are already doing
         that in the Frontend script and improved performance by at least 20
         percent there: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/115561#note_1324725274
      9d3f4829
  7. 4月 01, 2023
  8. 3月 31, 2023
  9. 3月 29, 2023
  10. 3月 23, 2023
  11. 3月 22, 2023
  12. 3月 21, 2023
  13. 3月 20, 2023
  14. 3月 16, 2023
  15. 3月 13, 2023
  16. 3月 09, 2023
    • Malcolm Locke's avatar
      Increase number of lines used in Danger feature_category scan · d7ce7098
      Malcolm Locke 创作于
      Danger currently reports feature_category as missing on the top
      level `RSpec.describe` if the describe declaration spans more than
      2 lines.
      
      OK:
      ```
      RSpec.describe SomeClass, :js,
        feature_category: 'category' do
      ```
      
      'Fetaure category missing':
      ```
      RSpec.describe SomeClass,
        :js,
        feature_category: 'category' do
      ```
      
      This change allows this check to support top level `RSpec.describe`
      declarations that span up to 5 lines.
      d7ce7098
  17. 3月 04, 2023
  18. 3月 03, 2023
    • Mayra Cabrera's avatar
      Skip package-and-test message on trivial MRs · 20ea5184
      Mayra Cabrera 创作于
      The execution of package-and-test pipeline is required on merge request
      targeting stable branches as a way to guarantee the changes introduced
      are compliant from the Quality side. This is not necessary for
      documentation changes or for merge request fixing flaky failures, so in
      this case it's fine to skip the Danger message.
      
      This commit updates the stable branch checks to skip the
      package-and-test message on trivial merge requests with documentation
      changes only or with fixes for flaky failures.
      
      Related to https://gitlab.com/gitlab-com/gl-infra/delivery/-/issues/2839
      20ea5184
  19. 3月 02, 2023
  20. 2月 24, 2023
  21. 2月 23, 2023
  22. 2月 22, 2023
  23. 2月 18, 2023
  24. 2月 17, 2023
  25. 2月 16, 2023
  26. 2月 09, 2023
  27. 2月 06, 2023
加载中