[ci skip]

Fix Vue 3 failing test for super_sidebar_spec

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/169153



Merged-by: Jacques Erasmus <jerasmus@gitlab.com>
Approved-by: Jack Chapman <jachapman@gitlab.com>
Approved-by: Jacques Erasmus <jerasmus@gitlab.com>
Reviewed-by: Artur Fedorov <afedorov@gitlab.com>
Co-authored-by: Artur Fedorov <afedorov@gitlab.com>

[ci skip]

Sync security_policies when project is added to group

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/168850



Merged-by: Andy Schoenen <asoiron@gitlab.com>
Approved-by: Martin Čavoj <mcavoj@gitlab.com>
Approved-by: Andy Schoenen <asoiron@gitlab.com>
Reviewed-by: Martin Čavoj <mcavoj@gitlab.com>
Co-authored-by: Sashi Kumar <skumar@gitlab.com>

This change adds a new worker to link
security_policies with a project when it is transferred
to a group or added to a group with security policies.

EE: true
Changelog: changed

Add reference ids for legacy epic related links and hierarchy

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/168122



Merged-by: Nicolas Dular <ndular@gitlab.com>
Approved-by: Adam Hegyi <ahegyi@gitlab.com>
Reviewed-by: Alexandru Croitor <acroitor@gitlab.com>
Reviewed-by: Duo Code Reviewer <duo-code-review-bot@gitlab.com>

To ensure in the future that every `epic_issue` has a
`work_item_parent_link` and every `related_epic_link` has a
RelatedWorkItemLink (which is stored in the `issue_links` table) we add
foreign keys to the legacy epic tables.

We also want to ensure that all deletions on the work item side are
reflected on the legacy epic side, we add ON DELETE CASCADE to these
foreign keys.

Once we backfilled the tables and set the correct foreign key on
creation, we can add a NOT NULL constraint to harden the relationship
between legacy epics and new epic work items.

Changelog: added
EE: true

Update database_lab.md

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/168811



Merged-by: Marius Bobin <mbobin@gitlab.com>
Approved-by: Alex Ives <aives@gitlab.com>
Approved-by: Marius Bobin <mbobin@gitlab.com>
Co-authored-by: Max Orefice <morefice@gitlab.com>

Merge branch 'quarantine-flaky-tests-ee-spec-services-system_notes-escalations_service_spec-rb-23' into 'master' 

Quarantine a flaky test

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/166800



Merged-by: David Dieulivol <ddieulivol@gitlab.com>
Approved-by: Ravi Kumar <rkumar@gitlab.com>
Co-authored-by: Auto-quarantining bot <gitlab-auto-quarantine-bot@gitlab.com>

Merge branch 'quarantine-flaky-tests-ee-spec-services-system_notes-escalations_service_spec-rb-42' into 'master' 

Quarantine a flaky test

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/166799



Merged-by: David Dieulivol <ddieulivol@gitlab.com>
Approved-by: Ravi Kumar <rkumar@gitlab.com>
Co-authored-by: Auto-quarantining bot <gitlab-auto-quarantine-bot@gitlab.com>

Add specs to test for_role scopes

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/168688



Merged-by: Joe Woodward <jwoodward@gitlab.com>
Approved-by: Vladimir Shushlin <vshushlin@gitlab.com>
Reviewed-by: Vladimir Shushlin <vshushlin@gitlab.com>
Reviewed-by: Nwanna Isong <nisong@gitlab.com>
Co-authored-by: Joe Woodward <j@joewoodward.me>

This change adds test to cover the for_role scope.

Also removes a duplicated spec which is already covered in the shared examples.

Merge branch 'quarantine-flaky-tests-ee-spec-lib-gitlab-llm-vertex_ai-model_configurations-chat_spec-rb-46' into 'master' 

Quarantine a flaky test

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/165742



Merged-by: David Dieulivol <ddieulivol@gitlab.com>
Approved-by: Alejandro Rodríguez <alejandro@gitlab.com>
Co-authored-by: Auto-quarantining bot <gitlab-auto-quarantine-bot@gitlab.com>

Merge branch 'quarantine-flaky-tests-ee-spec-lib-gitlab-llm-vertex_ai-model_configurations-text_spec-rb-40' into 'master' 

Quarantine a flaky test

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/164711



Merged-by: David Dieulivol <ddieulivol@gitlab.com>
Approved-by: Alejandro Rodríguez <alejandro@gitlab.com>
Co-authored-by: Auto-quarantining bot <gitlab-auto-quarantine-bot@gitlab.com>

Merge branch '471341-developer-role-users-do-not-see-the-cleanup-schedule-on-a-container-registry-2' into 'master' 

Update container registry settings to use new graphql fields

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/168805



Merged-by: Deepika Guliani <dguliani@gitlab.com>
Approved-by: Briley Sandlin <bsandlin@gitlab.com>
Approved-by: Deepika Guliani <dguliani@gitlab.com>
Co-authored-by: Rahul Chanila <rchanila@gitlab.com>

Fix flaky spec blobs/edit_spec

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/169071



Merged-by: David Dieulivol <ddieulivol@gitlab.com>
Approved-by: David Dieulivol <ddieulivol@gitlab.com>
Co-authored-by: Dylan Griffith <dyl.griffith@gmail.com>

Fix admin_mode enforcement in AdjournedProjectDeletionWorker

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/167779



Merged-by: Andrew Evans <aevans@gitlab.com>
Approved-by: Hinam Mehra <hmehra@gitlab.com>
Approved-by: Andrew Evans <aevans@gitlab.com>
Reviewed-by: Andrew Evans <aevans@gitlab.com>
Reviewed-by: Abdul Wadood <awadood@gitlab.com>
Reviewed-by: Duo Code Reviewer <duo-code-review-bot@gitlab.com>
Co-authored-by: Abdul Wadood <awadood@gitlab.com>

This change addresses an issue where project deletion fails when
scheduled by an admin with admin mode enabled. The problem occurs
because the `admin_mode` session value is not persisted to Sidekiq.

To resolve this, we introduce an `admin_mode` flag for
`ProjectDestroyWorker`, creating a temporary admin session for
project deletion. This approach ensures that other policy checks,
such as blocking or user permissions, remain enforced while
bypassing the admin_mode check. The admin_mode check should only be
performed when the deletion is scheduled. We have previously
implemented a similar solution for groups in a separate merge
request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/163071.

Changelog: fixed
EE: true

Add milestones to dashboard dev docs images

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/169371



Merged-by: Roshni Sarangadharan <rsarangadharan@gitlab.com>
Approved-by: Roshni Sarangadharan <rsarangadharan@gitlab.com>
Co-authored-by: Amy Qualls <aqualls@gitlab.com>

Add shared_context for protected ref access specs

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/168687



Merged-by: Shinya Maeda <shinya@gitlab.com>
Approved-by: david hamp-gonsalves <dhamp-gonsalves@gitlab.com>
Approved-by: Shinya Maeda <shinya@gitlab.com>
Co-authored-by: Joe Woodward <j@joewoodward.me>

Update Gitaly version

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/169383



Merged-by: release-tools approver bot <project_278964_bot_77e28085fcec07f14dfd31c689824b5b@noreply.gitlab.com>
Approved-by: release-tools approver bot <project_278964_bot_77e28085fcec07f14dfd31c689824b5b@noreply.gitlab.com>
Co-authored-by: GitLab Release Tools Bot <delivery-team+release-tools@gitlab.com>

[ci skip]

Update batching size documentation

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/168489



Merged-by: Krasimir Angelov <kangelov@gitlab.com>
Approved-by: Krasimir Angelov <kangelov@gitlab.com>
Reviewed-by: Max Orefice <morefice@gitlab.com>
Co-authored-by: Maxime Orefice <morefice@gitlab.com>

The `` SystemNotes::EscalationsService#start_escalation posts the correct text to the system note ``
test matches one of the following conditions:
1. has either ~"flakiness::1" or ~"flakiness::2" label set, which means the number of reported failures
is at or above 95 percentile, indicating unusually high failure count.

2. has ~"severity::1" label set, which means the number of reported failures
[spiked and exceeded its daily threshold](https://gitlab.com/gitlab-org/ruby/gems/gitlab_quality-test_tooling/-/blob/c9bc10536b1f8d2d4a03c3e0b6099a40fe67ad26/lib/gitlab_quality/test_tooling/report/concerns/issue_reports.rb#L51).

This MR quarantines the test. This is a discussion starting point to let the
responsible group know about the flakiness so that they can take action:

- accept the merge request and schedule the associated issue to improve the test
- close the merge request in favor of another merge request to delete the test

Please follow the
[Flaky tests management process](https://handbook.gitlab.com/handbook/engineering/infrastructure/engineering-productivity/flaky-tests-management-and-processes/#flaky-tests-management-process)
to help us increase `master` stability.

Please let us know your feedback in the
[Engineering Productivity issue tracker](https://gitlab.com/gitlab-org/quality/engineering-productivity/team/-/issues).

Related to https://gitlab.com/gitlab-org/gitlab/-/issues/484427.

This change was generated by
[gitlab-housekeeper](https://gitlab.com/gitlab-org/gitlab/-/tree/master/gems/gitlab-housekeeper)
using the Keeps::QuarantineFlakyTests keep.

To provide feedback on your experience with `gitlab-housekeeper` please create an issue with the
label ~"GitLab Housekeeper" and consider pinging the author of this keep.

Changelog: other

The `` SystemNotes::EscalationsService#notify_via_escalation posts the correct text to the system note ``
test matches one of the following conditions:
1. has either ~"flakiness::1" or ~"flakiness::2" label set, which means the number of reported failures
is at or above 95 percentile, indicating unusually high failure count.

2. has ~"severity::1" label set, which means the number of reported failures
[spiked and exceeded its daily threshold](https://gitlab.com/gitlab-org/ruby/gems/gitlab_quality-test_tooling/-/blob/c9bc10536b1f8d2d4a03c3e0b6099a40fe67ad26/lib/gitlab_quality/test_tooling/report/concerns/issue_reports.rb#L51).

This MR quarantines the test. This is a discussion starting point to let the
responsible group know about the flakiness so that they can take action:

- accept the merge request and schedule the associated issue to improve the test
- close the merge request in favor of another merge request to delete the test

Please follow the
[Flaky tests management process](https://handbook.gitlab.com/handbook/engineering/infrastructure/engineering-productivity/flaky-tests-management-and-processes/#flaky-tests-management-process)
to help us increase `master` stability.

Please let us know your feedback in the
[Engineering Productivity issue tracker](https://gitlab.com/gitlab-org/quality/engineering-productivity/team/-/issues).

Related to https://gitlab.com/gitlab-org/gitlab/-/issues/484424.

This change was generated by
[gitlab-housekeeper](https://gitlab.com/gitlab-org/gitlab/-/tree/master/gems/gitlab-housekeeper)
using the Keeps::QuarantineFlakyTests keep.

To provide feedback on your experience with `gitlab-housekeeper` please create an issue with the
label ~"GitLab Housekeeper" and consider pinging the author of this keep.

Changelog: other

From our
[screenshots in CI](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/169071#note_2158785549)
we were able to determine that there was no diff to preview in this
spec. After looking more closely into the code we can see that the test
is relying on this `edit_and_commit` to update the code each time. But
depending on the test order we can see logically that the content is not
necessarily changed by calling `edit_and_commit`. This is because we use
`let_it_be(:project` so the project is re-used between specs. If the
last spec also calls this method then the content will be the same and
there will not be any diff to preview or commit.

We can see the spec fails consistently (without this change) if the
order is:

```
Editing file blob
  as a developer
    updates the content of file with a number as file path
    editing a template file in a sub directory does not change path
    updating file path updates syntax highlighting
    from MR diff
      returns me to the mr
    blob edit toolbar
      has defined set of toolbar buttons when the flag is on
      has defined set of toolbar buttons when the flag is off
    from blob file path
      updates content
      previews content
```

This MR fixes the problem by just appending `object_id` to the content
so that it is different every time it runs. The `object_id` is unique to
every test example.

In addition to this the previous implementation does not seem to robustly wait for the
element to appear. It does rely on `wait_for_requests` but I don't think
this is as reliable as using Capybara's default when using `have_`
matchers. The `have_css` matcher should wait for a specific amount of
time for the element to appear. And it will timeout if the element does
not appear in time. This seems more robust than counting the lines which
appear after a `wait_for_requests`. The counting was also not needed as
we're only checking for `> 0` so we may as well just wait for something
to appear.

This is in an effort to fix the flaky spec described at
https://gitlab.com/gitlab-org/gitlab/-/issues/448293 .

Retry exit code 111

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/169340



Merged-by: Nao Hashizume <nhashizume@gitlab.com>
Approved-by: Nao Hashizume <nhashizume@gitlab.com>
Co-authored-by: Jennifer Li <jli@gitlab.com>

Show the ages of these images.

Fix flaky cycle analytics spec

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/168990



Merged-by: Felipe Cardozo <fcardozo@gitlab.com>
Approved-by: Prabakaran Murugesan <pmurugesan@gitlab.com>
Approved-by: Pavel Shutsin <pshutsin@gitlab.com>
Co-authored-by: Felipe Artur <felipefac@gmail.com>

Include project ancestors when determining agent user access

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/167868



Merged-by: Michał Zając <mzajac@gitlab.com>
Approved-by: Timo Furrer <tfurrer@gitlab.com>
Approved-by: Michał Zając <mzajac@gitlab.com>
Reviewed-by: Tiger Watson <twatson@gitlab.com>
Co-authored-by: Taka Nishida <tnishida@gitlab.com>
Co-authored-by: Tiger <twatson@gitlab.com>

Changelog: fixed

Document editor extension https and proxy variable usage

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/165944



Merged-by: Amy Qualls <aqualls@gitlab.com>
Approved-by: Amy Qualls <aqualls@gitlab.com>
Co-authored-by: Erran Carey <ecarey@gitlab.com>

Let's set up a permanent home for internal Language Server docs
we want to publish on docs.gitlab.com. It should be in the
doc/development directory to convey this is not user-facing
documentation.

Merge branch '498297-add-comment-on-vue-transition-classes-so-that-we-do-not-accidently-remove-them-2' into 'master' 

Move all Vue transition classes into vue_transitions.scss

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/168752



Merged-by: Scott de Jonge <sdejonge@gitlab.com>
Approved-by: Scott de Jonge <sdejonge@gitlab.com>
Co-authored-by: James Rushford <jrushford@gitlab.com>

Put Geo::MetricsUpdateWorker behind a feature flag

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/169346



Merged-by: Michael Kozono <mkozono@gitlab.com>
Approved-by: Michael Kozono <mkozono@gitlab.com>
Co-authored-by: Douglas Barbosa Alexandre <dbalexandre@gmail.com>

Adding back in "argument list too long"

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/169014



Merged-by: Marcel Amirault <mamirault@gitlab.com>
Approved-by: Marcel Amirault <mamirault@gitlab.com>
Reviewed-by: Marcel Amirault <mamirault@gitlab.com>
Co-authored-by: Duncan <drharris@gitlab.com>

Add the bootstrap command to the agent creation modal

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/169188



Merged-by: Coung Ngo <cngo@gitlab.com>
Approved-by: Sunjung Park <spark@gitlab.com>
Approved-by: Anna Vovchenko <avovchenko@gitlab.com>
Approved-by: Coung Ngo <cngo@gitlab.com>
Reviewed-by: Coung Ngo <cngo@gitlab.com>
Reviewed-by: Timo Furrer <tfurrer@gitlab.com>
Co-authored-by: Anton Kalmykov <anton.kalmykov@proton.me>