This reverts commit a5923aa6, which
reverted the relative_positioning improvements.

This reverts merge request !37724

This expands the usable range of positions to the negative numbers,
uses more precisely chosen gap sizes, and deals more effectively with
edge cases.

Move existing offences to todo

This MR fixes the Rails/SaveBang cop
for spec files in
spec/features/merge_requests/*

It also adds a changelog for the
mentioned change

Add changelog for the cop fixes

Use sidekiq inline in spec

Since Gitlab 13.2, Geo don't rely on FDW

- comply to style guide.

- follow style guide

- comply to style guide

- enforce standards...

- no exceptions...

- standards/style guide enforcement

This MR fixes the Rails/SaveBang Cop
and removes the files from .rubocop_todo.yml

Add changelog for the cop fixes

Fix failing spec in MR finder spec

This MR fixes the Rails/SaveBand cop for files
in spec/workers/* and remove them from
.rubocop_todo.yml

Add changelog for the spec fixes

Add changelog for the cop fixes

This MR fixes Rails/SaveBang cop issues
in all files of ee/spec/features folder

Add changelog for the cop fixes

- no exceptions...

This MR fixes Rails/SaveBang cop for spec files in policies folder.

Add changelog for the fix

Fix specs that were failing due to change

Avoid method redefinitions by removing the corresponding
`attr_{reader,writer,accessor}`.

- enforce new line after let block rule.
- ignore existing offenses to be fixed in follow up:
  https://gitlab.com/gitlab-org/gitlab/-/issues/228860

FYI the existing offenses list was generated by running:

  bundle exec rubocop --auto-gen-config \
    --only "RSpec/EmptyLineAfterLetBlock" \
    --exclude-limit 1000

This removes an old background migration which isn't needed anymore (not
called from anywhere).

- enforce performant code and style guides

- package finders and specs
- package apis and specs
- package services and specs
- package presenters and specs
- package graphql resolver

- for new cop to be enabled later

This commit also fixes the existing offenses

Moving services and finders to core in
preparation for moving the packages
feature to core.

- move package models to core
- split package file GEO code into EE
- move package services to core
- move package factories to core

This rule prevents usage of nonbang actions inside block/method.
This commit also adds ActionDispatch::TestRequest into AllowedReceivers,
in order to prevent accidental usage of bang operator.