This will give the frontend the ability to fetch a specific set of
deploy keys at at time, reducing page load times and DB query time.

- spec/[b-f]*/**/*.rb

Fix offenses in controllers and controllers' specs

Contributes to https://gitlab.com/gitlab-org/gitlab/-/issues/239356

Changelog: fixed
EE: true

Use a single succinct error message when a deploy key is invalid
instead of returning all validation errors.

Changelog: fixed

This fixes all remaining files and removes the todo file

The plan for RSpec 4.0 is to disable monkey patching:
https://rspec.info/blog/2013/07/the-plan-for-rspec-3/#zero-monkey-patching-mode

This commit stops using RSpec monkey patching:
https://relishapp.com/rspec/rspec-core/docs/configuration/zero-monkey-patching-mode

Removed hidden deploy_keys_project id from form
Added before_action to DeployKey controller update.
Added rspec accordingly.

Reverted changes in controllers, views and rspecs.
Reverted changes in documentation.
Added changelog file.

Updated existing rspecs.
Moved Deploy Keys feature specs into new file.

126 files inspected, 429 offenses detected, 429 offenses corrected

- Add test to prevent further N+1 queries

Prefer `json_response` where applicable.

Prefer `json_response` where applicable.

Adds frozen string to the following:

* spec/bin/**/*.rb
* spec/config/**/*.rb
* spec/controllers/**/*.rb

xref https://gitlab.com/gitlab-org/gitlab-ce/issues/59758

Signed-off-by: Rémy Coutable <remy@rymai.me>

Signed-off-by: Rémy Coutable <remy@rymai.me>

Updates specs to use new rails5 format.

The old format:
`get :show, { some: params }, { some: headers }`

The new format:
`get :show, params: { some: params }, headers: { some: headers }`

Updates specs to use new rails5 format.

The old format:
`get :show, { some: params }, { some: headers }`

The new format:
`get :show, params: { some: params }, headers: { some: headers }`

Admins would be prevented from adding a project deploy key since the
accessible keys would be restricted to the user's keys.

Also backports a spec for DeployKeysController from
https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/8432.

In EE, the DeployKeyController reloads the user's accesible key so that
it can audit changes. However, this has a side effect of preventing
admins from deleting keys in the interface.  Note that the deletion
problem does not happen in CE because auditing is not performed there.

We can clean up the code by reusing the key that was created or destroyed
and pushing the logic into the service.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/53783