Skip to content
代码片段 群组 项目
未验证 提交 fea6d70c 编辑于 作者: David Dieulivol's avatar David Dieulivol 提交者: GitLab
浏览文件

Add a test mapping for lib/sidebars

Whenever we change ruby files in this folder, we'll run
feature specs for the correct edition that would contain
the word "navbar" or "sidebar".
上级 fcf1c82e
No related branches found
No related tags found
无相关合并请求
......@@ -68,6 +68,15 @@ tests = [
]
},
{
explanation: 'https://gitlab.com/gitlab-org/gitlab/-/issues/466068#note_1987902951',
changed_file: 'ee/lib/audit_events/strategies/instance/amazon_s3_destination_strategy.rb',
expected: %w[
ee/spec/lib/audit_events/strategies/instance/amazon_s3_destination_strategy_spec.rb
ee/spec/lib/audit_events/external_destination_streamer_spec.rb
]
},
{
explanation: 'Tooling should map to respective spec',
changed_file: 'tooling/danger/specs/project_factory_suggestion.rb',
......@@ -461,6 +470,52 @@ tests = [
ee/spec/requests/api/graphql/remote_development/workspace/with_id_arg_spec.rb
]
},
{
explanation: 'https://gitlab.com/gitlab-org/gitlab/-/issues/466068#note_1987834618',
changed_file: 'ee/app/replicators/geo/ci_secure_file_replicator.rb',
expected: %w[
ee/spec/replicators/geo/ci_secure_file_replicator_spec.rb
ee/spec/models/geo_node_status_spec.rb
]
},
# Why is it commented out?
#
# We cannot uncomment this, as this "spec" would fail as soon as we add/remove a file in
# the "spec/features" folder hierarchy that would contain the word navbar/sidebar.
#
# {
# explanation: 'https://gitlab.com/gitlab-org/gitlab/-/issues/466068#note_1988359861',
# changed_file: 'lib/sidebars/projects/menus/issues_menu.rb',
# expected: %w[
# spec/features/boards/sidebar_spec.rb
# spec/features/dashboard/navbar_spec.rb
# spec/features/explore/navbar_spec.rb
# spec/features/groups/navbar_spec.rb
# spec/features/projects/navbar_spec.rb
# spec/lib/sidebars/projects/menus/issues_menu_spec.rb
# ]
# },
# Why is it commented out?
#
# We cannot uncomment this, as this "spec" would fail as soon as we add/remove a file in
# the "spec/features" folder hierarchy that would contain the word navbar/sidebar.
#
# {
# explanation: 'https://gitlab.com/gitlab-org/gitlab/-/issues/466068#note_1988359861',
# changed_file: 'ee/lib/sidebars/groups/menus/epics_menu.rb',
# expected: %w[
# ee/spec/features/boards/sidebar_spec.rb
# ee/spec/features/dashboard/navbar_spec.rb
# ee/spec/features/groups/navbar_spec.rb
# ee/spec/features/merge_request/sidebar_spec.rb
# ee/spec/features/projects/navbar_spec.rb
# ee/spec/lib/sidebars/groups/menus/epics_menu_spec.rb
# ]
# },
{
explanation: 'Run database dictionary related specs on db/docs changes.',
changed_file: 'db/docs/design_management_repositories.yml',
......
......@@ -29,6 +29,10 @@ mapping:
- source: 'ee/lib/gitlab/ci/config/(?<rest>.+)\.rb'
test: 'ee/spec/lib/gitlab/ci/yaml_processor_spec.rb'
# See https://gitlab.com/gitlab-org/gitlab/-/issues/466068#note_1987902951
- source: 'ee/lib/audit_events/strategies/(?<rest>.+)\.rb'
test: 'ee/spec/lib/audit_events/external_destination_streamer_spec.rb'
# FOSS tooling should map to respective spec
- source: 'tooling/(?<rest>.+)\.rb'
test: 'spec/tooling/%{rest}_spec.rb'
......@@ -208,3 +212,13 @@ mapping:
- source: 'public/robots\.txt'
test:
- 'spec/requests/robots_txt_spec.rb'
# See https://gitlab.com/gitlab-org/gitlab/-/issues/466068#note_1987834618
- source: 'ee/app/replicators/geo/(?<rest>.+)\.rb'
test: 'ee/spec/models/geo_node_status_spec.rb'
# Any change to lib/sidebars/**/*.rb should map to specs that contain the words `sidebar` or `navbar`
#
# See https://gitlab.com/gitlab-org/gitlab/-/issues/466068#note_1988359861
- source: '(?<prefix>ee/)?lib/sidebars/(?<rest>.+)\.rb'
test: '%{prefix}spec/features/**/{navbar,sidebar}_spec.rb'
0% 加载中 .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册