Merge branch 're-enable-hamlt-lint-docs-pipelines' into 'master'

Re-enable haml-lint in docs pipelines

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/168195



Merged-by: Kev Kloss <kkloss@gitlab.com>
Approved-by: Kev Kloss <kkloss@gitlab.com>
Approved-by: Joe Woodward <jwoodward@gitlab.com>
Co-authored-by: Marcel Amirault <mamirault@gitlab.com>

.gitlab/ci/docs.gitlab-ci.yml

@@ -95,19 +95,15 @@ docs-lint links:
   script:
     - lychee --offline --no-progress --include-fragments doc
 
-#
-# Disabled while links are being cleaned up.
-# See: https://gitlab.com/gitlab-org/gitlab/-/issues/419673
-#
-# ui-docs-links lint:
-#   extends:
-#     - .docs:rules:docs-lint
-#     - .static-analysis-base
-#     - .ruby-cache
-#   stage: lint
-#   needs: []
-#   script:
-#     - bundle exec haml-lint -i DocumentationLinks
+ui-docs-links lint:
+  extends:
+    - .docs:rules:docs-lint
+    - .static-analysis-base
+    - .ruby-cache
+  stage: lint
+  needs: []
+  script:
+    - bundle exec haml-lint -i DocumentationLinks
 
 docs-lint deprecations-and-removals:
   variables:

spec/features/projects/settings/branch_rules_callout_spec.rb

@@ -23,7 +23,7 @@
     it 'displays callout on repository settings page' do
       expect(page).to have_content callout_message
       expect(page).to have_link('How to use branch rules',
-        href: help_page_path('user/project/repository/branches/index.md', anchor: 'create-a-branch-rule'))
+        href: help_page_path('user/project/repository/branches/branch_rules.md', anchor: 'create-a-branch-rule'))
     end
 
     context 'when callout is dismissed', :js do