Merge branch 'pl-rubocop-enable-rspec-scattered-let' into 'master'

RuboCop: Enable previously disabled cop RSpec/ScatteredLet

See merge request gitlab-org/gitlab!92897

.rubocop_todo/rspec/scattered_let.yml

 ---
 # Cop supports --auto-correct.
 RSpec/ScatteredLet:
-  # Offense count: 720
-  # Temporarily disabled due to too many offenses
-  Enabled: false
   Exclude:
     - 'ee/spec/features/groups/group_roadmap_spec.rb'
     - 'ee/spec/features/merge_trains/two_merge_requests_on_train_spec.rb'
@@ -19,10 +16,10 @@ RSpec/ScatteredLet:
     - 'ee/spec/graphql/types/instance_security_dashboard_type_spec.rb'
     - 'ee/spec/helpers/ee/subscribable_banner_helper_spec.rb'
     - 'ee/spec/helpers/trial_status_widget_helper_spec.rb'
-    - 'ee/spec/lib/banzai/reference_parser/iteration_parser_spec.rb'
     - 'ee/spec/lib/ee/audit/compliance_framework_changes_auditor_spec.rb'
     - 'ee/spec/lib/ee/gitlab/ci/config_spec.rb'
     - 'ee/spec/lib/ee/gitlab/email/handler/service_desk_handler_spec.rb'
+    - 'ee/spec/lib/gitlab/background_migration/migrate_requirements_to_work_items_spec.rb'
     - 'ee/spec/lib/gitlab/ci/parsers/security/dast_spec.rb'
     - 'ee/spec/lib/gitlab/ci/parsers/security/formatters/dependency_list_spec.rb'
     - 'ee/spec/lib/gitlab/ci/templates/dast_api_gitlab_ci_yaml_spec.rb'
@@ -62,9 +59,12 @@ RSpec/ScatteredLet:
     - 'ee/spec/requests/api/graphql/project/pipelines/dast_profile_spec.rb'
     - 'ee/spec/requests/api/internal/base_spec.rb'
     - 'ee/spec/requests/api/projects_spec.rb'
+    - 'ee/spec/requests/api/settings_spec.rb'
     - 'ee/spec/requests/api/vulnerability_findings_spec.rb'
     - 'ee/spec/requests/git_http_geo_spec.rb'
+    - 'ee/spec/serializers/license_compliance/collapsed_comparer_entity_spec.rb'
     - 'ee/spec/serializers/status_page/incident_serializer_spec.rb'
+    - 'ee/spec/services/app_sec/dast/scan_configs/fetch_service_spec.rb'
     - 'ee/spec/services/app_sec/dast/scanner_profiles/update_service_spec.rb'
     - 'ee/spec/services/arkose/blocked_users_report_service_spec.rb'
     - 'ee/spec/services/arkose/user_verification_service_spec.rb'
@@ -88,13 +88,13 @@ RSpec/ScatteredLet:
     - 'ee/spec/services/requirements_management/update_requirement_service_spec.rb'
     - 'ee/spec/services/search/group_service_spec.rb'
     - 'ee/spec/services/search/project_service_spec.rb'
+    - 'ee/spec/services/security/ingestion/tasks/update_vulnerability_uuids_spec.rb'
     - 'ee/spec/services/todo_service_spec.rb'
     - 'ee/spec/views/shared/_mirror_update_button.html.haml_spec.rb'
     - 'ee/spec/views/subscriptions/groups/edit.html.haml_spec.rb'
     - 'ee/spec/workers/compliance_management/merge_requests/compliance_violations_worker_spec.rb'
     - 'ee/spec/workers/concerns/update_orchestration_policy_configuration_spec.rb'
     - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_audit_logs_1_spec.rb'
-    - 'qa/qa/specs/features/ee/browser_ui/1_manage/project/project_audit_logs_spec.rb'
     - 'spec/controllers/projects/artifacts_controller_spec.rb'
     - 'spec/controllers/projects/deploy_keys_controller_spec.rb'
     - 'spec/controllers/projects/environments_controller_spec.rb'
@@ -126,14 +126,19 @@ RSpec/ScatteredLet:
     - 'spec/lib/banzai/reference_parser/project_parser_spec.rb'
     - 'spec/lib/banzai/reference_parser/snippet_parser_spec.rb'
     - 'spec/lib/banzai/reference_parser/user_parser_spec.rb'
+    - 'spec/lib/bulk_imports/pipeline/runner_spec.rb'
     - 'spec/lib/bulk_imports/projects/pipelines/snippets_repository_pipeline_spec.rb'
     - 'spec/lib/gitlab/asciidoc/include_processor_spec.rb'
     - 'spec/lib/gitlab/auth/ldap/person_spec.rb'
     - 'spec/lib/gitlab/auth/saml/auth_hash_spec.rb'
+    - 'spec/lib/gitlab/background_migration/backfill_imported_issue_search_data_spec.rb'
     - 'spec/lib/gitlab/background_migration/copy_ci_builds_columns_to_security_scans_spec.rb'
+    - 'spec/lib/gitlab/background_migration/disable_legacy_open_source_license_for_inactive_public_projects_spec.rb'
     - 'spec/lib/gitlab/background_migration/encrypt_static_object_token_spec.rb'
     - 'spec/lib/gitlab/background_migration/legacy_uploads_migrator_spec.rb'
     - 'spec/lib/gitlab/background_migration/nullify_orphan_runner_id_on_ci_builds_spec.rb'
+    - 'spec/lib/gitlab/background_migration/reset_too_many_tags_skipped_registry_imports_spec.rb'
+    - 'spec/lib/gitlab/background_migration/set_legacy_open_source_license_available_for_non_public_projects_spec.rb'
     - 'spec/lib/gitlab/background_migration/update_jira_tracker_data_deployment_type_based_on_url_spec.rb'
     - 'spec/lib/gitlab/ci/config/external/file/artifact_spec.rb'
     - 'spec/lib/gitlab/ci/pipeline/chain/helpers_spec.rb'
@@ -162,6 +167,7 @@ RSpec/ScatteredLet:
     - 'spec/lib/gitlab/git/blame_spec.rb'
     - 'spec/lib/gitlab/git/diff_collection_spec.rb'
     - 'spec/lib/gitlab/git_access_spec.rb'
+    - 'spec/lib/gitlab/github_import/importer/single_endpoint_issue_events_importer_spec.rb'
     - 'spec/lib/gitlab/github_import/parallel_scheduling_spec.rb'
     - 'spec/lib/gitlab/import_export/group/relation_tree_restorer_spec.rb'
     - 'spec/lib/gitlab/import_export/project/export_task_spec.rb'
@@ -182,7 +188,6 @@ RSpec/ScatteredLet:
     - 'spec/lib/gitlab/spamcheck/client_spec.rb'
     - 'spec/lib/gitlab/template/finders/global_template_finder_spec.rb'
     - 'spec/lib/gitlab/tree_summary_spec.rb'
-    - 'spec/lib/gitlab/usage/service_ping_report_spec.rb'
     - 'spec/lib/gitlab/usage_data_metrics_spec.rb'
     - 'spec/lib/gitlab/utils/measuring_spec.rb'
     - 'spec/lib/gitlab/zentao/client_spec.rb'
@@ -236,6 +241,7 @@ RSpec/ScatteredLet:
     - 'spec/requests/api/project_clusters_spec.rb'
     - 'spec/requests/api/project_export_spec.rb'
     - 'spec/requests/api/rubygem_packages_spec.rb'
+    - 'spec/requests/jira_routing_spec.rb'
     - 'spec/requests/projects/releases_controller_spec.rb'
     - 'spec/rubocop/cop/migration/update_column_in_batches_spec.rb'
     - 'spec/scripts/pipeline_test_report_builder_spec.rb'
@@ -277,6 +283,8 @@ RSpec/ScatteredLet:
     - 'spec/services/system_notes/design_management_service_spec.rb'
     - 'spec/services/system_notes/merge_requests_service_spec.rb'
     - 'spec/services/todo_service_spec.rb'
+    - 'spec/services/web_hook_service_spec.rb'
+    - 'spec/services/work_items/update_service_spec.rb'
     - 'spec/support/shared_examples/graphql/sorted_paginated_query_shared_examples.rb'
     - 'spec/tasks/gitlab/artifacts/migrate_rake_spec.rb'
     - 'spec/workers/concerns/gitlab/github_import/object_importer_spec.rb'