Merge branch 'ml-model-versions-semver-backfill' into 'master'

Update ML Model Versions to use semver module

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/144257



Merged-by: Etienne Baqué <ebaque@gitlab.com>
Approved-by: Etienne Baqué <ebaque@gitlab.com>
Reviewed-by: Darby Frey <dfrey@gitlab.com>
Reviewed-by: Etienne Baqué <ebaque@gitlab.com>
Reviewed-by: Brian Williams <bwilliams@gitlab.com>
Reviewed-by: Eduardo Bonet <ebonet@gitlab.com>
Co-authored-by: Darby Frey <dfrey@gitlab.com>

app/models/ml/model_version.rb

@@ -7,6 +7,7 @@ class ModelVersion < ApplicationRecord
     include SemanticVersionable
 
     semver_method :semver
+    validate_semver
 
     validates :project, :model, presence: true
 
@@ -63,6 +64,11 @@ def by_project_id_name_and_version(project_id, name, version)
       end
     end
 
+    def version=(value)
+      self.semver = value
+      super(value)
+    end
+
     private
 
     def valid_model?

spec/models/ml/model_version_spec.rb

@@ -47,12 +47,13 @@
 
     describe 'version' do
       where(:ctx, :version) do
-        'version is blank'                     | ''
-        'version is not valid package version' | '!!()()'
-        'version is too large'                 | ('a' * 256)
+        'can\'t be blank'                         | ''
+        'is invalid'                              | '!!()()'
+        'is too long (maximum is 255 characters)' | ('a' * 256)
+        'must follow semantic version'            | '1'
       end
       with_them do
-        it { expect(errors).to include(:version) }
+        it { expect(errors.messages.values.flatten).to include(ctx) }
       end
 
       context 'when version is not unique in project+name' do
@@ -272,7 +273,7 @@
   end
 
   context 'when parsing semver components' do
-    let(:model_version) { build(:ml_model_versions, model: model1, semver: semver, project: base_project) }
+    let(:model_version) { build(:ml_model_versions, model: model1, version: semver, project: base_project) }
 
     where(:semver, :valid, :major, :minor, :patch, :prerelease) do
       '1'             | false | nil | nil | nil | nil