Merge branch '430843-remove-temporary-indexes' into 'master'

Remove temporary index for migration

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/136787



Merged-by: Adam Hegyi <ahegyi@gitlab.com>
Approved-by: Adam Hegyi <ahegyi@gitlab.com>
Reviewed-by: Tianwen Chen <tchen@gitlab.com>
Co-authored-by: j.seto <jseto@gitlab.com>

db/docs/batched_background_migrations/delete_invalid_protected_branch_merge_access_levels.yml

@@ -5,3 +5,4 @@ feature_category: source_code_management
 introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/134337
 milestone: '16.6'
 queued_migration_version: 20231016173129
+finalized_by: 20240111195101

db/docs/batched_background_migrations/delete_invalid_protected_branch_push_access_levels.yml

@@ -5,3 +5,4 @@ feature_category: source_code_management
 introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/134337
 milestone: '16.6'
 queued_migration_version: 20231016194927
+finalized_by: 20240111194808

db/docs/batched_background_migrations/delete_invalid_protected_tag_create_access_levels.yml

@@ -5,3 +5,4 @@ feature_category: source_code_management
 introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/134337
 milestone: '16.6'
 queued_migration_version: 20231016194943
+finalized_by: 20240111194603

db/post_migrate/20240111194603_finalize_delete_invalid_protected_tag_create_access_levels.rb

+# frozen_string_literal: true
+
+class FinalizeDeleteInvalidProtectedTagCreateAccessLevels < Gitlab::Database::Migration[2.2]
+  milestone '16.8'
+  MIGRATION = 'DeleteInvalidProtectedTagCreateAccessLevels'
+
+  disable_ddl_transaction!
+  restrict_gitlab_migration gitlab_schema: :gitlab_main
+
+  def up
+    ensure_batched_background_migration_is_finished(
+      job_class_name: MIGRATION,
+      table_name: :protected_tag_create_access_levels,
+      column_name: :id,
+      job_arguments: [],
+      finalize: true
+    )
+  end
+
+  def down
+    # no-op
+  end
+end

db/post_migrate/20240111194658_drop_temp_index_on_protected_tag_create_access_levels.rb

+# frozen_string_literal: true
+
+class DropTempIndexOnProtectedTagCreateAccessLevels < Gitlab::Database::Migration[2.2]
+  disable_ddl_transaction!
+  milestone '16.8'
+
+  INDEX_NAME = 'tmp_idx_protected_tag_create_access_levels_on_id_with_group'
+
+  def up
+    remove_concurrent_index_by_name(
+      :protected_tag_create_access_levels,
+      INDEX_NAME
+    )
+  end
+
+  def down
+    add_concurrent_index(
+      :protected_tag_create_access_levels,
+      %i[id],
+      where: 'group_id IS NOT NULL',
+      name: INDEX_NAME
+    )
+  end
+end

db/post_migrate/20240111194808_finalize_delete_invalid_protected_branch_push_access_levels.rb

+# frozen_string_literal: true
+
+class FinalizeDeleteInvalidProtectedBranchPushAccessLevels < Gitlab::Database::Migration[2.2]
+  milestone '16.8'
+  MIGRATION = 'DeleteInvalidProtectedBranchPushAccessLevels'
+
+  disable_ddl_transaction!
+  restrict_gitlab_migration gitlab_schema: :gitlab_main
+
+  def up
+    ensure_batched_background_migration_is_finished(
+      job_class_name: MIGRATION,
+      table_name: :protected_branch_push_access_levels,
+      column_name: :id,
+      job_arguments: [],
+      finalize: true
+    )
+  end
+
+  def down
+    # no-op
+  end
+end

db/post_migrate/20240111194925_drop_temp_index_on_protected_branch_push_access_levels.rb

+# frozen_string_literal: true
+
+class DropTempIndexOnProtectedBranchPushAccessLevels < Gitlab::Database::Migration[2.2]
+  disable_ddl_transaction!
+  milestone '16.8'
+
+  INDEX_NAME = 'tmp_idx_protected_branch_push_access_levels_on_id_with_group'
+
+  def up
+    remove_concurrent_index_by_name(
+      :protected_branch_push_access_levels,
+      INDEX_NAME
+    )
+  end
+
+  def down
+    add_concurrent_index(
+      :protected_branch_push_access_levels,
+      %i[id],
+      where: 'group_id IS NOT NULL',
+      name: INDEX_NAME
+    )
+  end
+end

db/post_migrate/20240111195101_finalize_delete_invalid_protected_branch_merge_access_levels.rb

+# frozen_string_literal: true
+
+class FinalizeDeleteInvalidProtectedBranchMergeAccessLevels < Gitlab::Database::Migration[2.2]
+  milestone '16.8'
+  MIGRATION = 'DeleteInvalidProtectedBranchMergeAccessLevels'
+
+  disable_ddl_transaction!
+  restrict_gitlab_migration gitlab_schema: :gitlab_main
+
+  def up
+    ensure_batched_background_migration_is_finished(
+      job_class_name: MIGRATION,
+      table_name: :protected_branch_merge_access_levels,
+      column_name: :id,
+      job_arguments: [],
+      finalize: true
+    )
+  end
+
+  def down
+    # no-op
+  end
+end

db/post_migrate/20240111195145_drop_temp_index_on_protected_branch_merge_access_levels.rb

+# frozen_string_literal: true
+
+class DropTempIndexOnProtectedBranchMergeAccessLevels < Gitlab::Database::Migration[2.2]
+  disable_ddl_transaction!
+  milestone '16.8'
+
+  INDEX_NAME = 'tmp_idx_protected_branch_merge_access_levels_on_id_with_group'
+
+  def up
+    remove_concurrent_index_by_name(
+      :protected_branch_merge_access_levels,
+      INDEX_NAME
+    )
+  end
+
+  def down
+    add_concurrent_index(
+      :protected_branch_merge_access_levels,
+      %i[id],
+      where: 'group_id IS NOT NULL',
+      name: INDEX_NAME
+    )
+  end
+end

db/schema_migrations/20240111194603

+cd476c18128010183f94f09c4543716f2e3bdd78c11209dcec500d5506e3f7b2
\ No newline at end of file

db/schema_migrations/20240111194658

+5f10603c43a631785057b2ad8c5f4e0de84c2499b3f862b5b851e28a3c9769ea
\ No newline at end of file

db/schema_migrations/20240111194808

+80a807f90560abd387b7579255e2301ba3b8bde4f25ca4ff1ecb83e4b3b42163
\ No newline at end of file

db/schema_migrations/20240111194925

+7cf8a9d321e212f49de7419a3827e3c18504f7a98900738c1fb7e82661743c92
\ No newline at end of file

db/schema_migrations/20240111195101

+560e3a35eee5ace51635ebc504d785b6008914316e8078a68f7cb735e14fc6c1
\ No newline at end of file

db/schema_migrations/20240111195145

+6e6b2669c731d4922cbe42adf003b5b934f4690a5466b166b9112f05681db62b
\ No newline at end of file

db/structure.sql

@@ -36132,12 +36132,6 @@ CREATE INDEX tmp_idx_orphaned_approval_merge_request_rules ON approval_merge_req
 CREATE INDEX tmp_idx_orphaned_approval_project_rules ON approval_project_rules USING btree (id) WHERE ((report_type = ANY (ARRAY[2, 4])) AND (security_orchestration_policy_configuration_id IS NULL));
-CREATE INDEX tmp_idx_protected_branch_merge_access_levels_on_id_with_group ON protected_branch_merge_access_levels USING btree (id) WHERE (group_id IS NOT NULL);
-
-CREATE INDEX tmp_idx_protected_branch_push_access_levels_on_id_with_group ON protected_branch_push_access_levels USING btree (id) WHERE (group_id IS NOT NULL);
-
-CREATE INDEX tmp_idx_protected_tag_create_access_levels_on_id_with_group ON protected_tag_create_access_levels USING btree (id) WHERE (group_id IS NOT NULL);
-
 CREATE INDEX tmp_index_ci_job_artifacts_on_expire_at_where_locked_unknown ON ci_job_artifacts USING btree (expire_at, job_id) WHERE ((locked = 2) AND (expire_at IS NOT NULL));
 CREATE INDEX tmp_index_cis_vulnerability_reads_on_id ON vulnerability_reads USING btree (id) WHERE (report_type = 7);