Merge branch 'remove-duplicated-indexes-board_user_preferences' into 'master'

Remove duplicated index from board_user_preferences

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/155508



Merged-by: Rodrigo Tomonari <rtomonari@gitlab.com>
Approved-by: Heinrich Lee Yu <heinrich@gitlab.com>
Approved-by: Jon Jenkins <jjenkins@gitlab.com>
Approved-by: Rodrigo Tomonari <rtomonari@gitlab.com>
Co-authored-by: Leonardo Rosa <ldarosa@gitlab.com>

db/post_migrate/20240605232454_drop_index_board_user_preferences_on_user_id.rb

+# frozen_string_literal: true
+
+class DropIndexBoardUserPreferencesOnUserId < Gitlab::Database::Migration[2.2]
+  milestone '17.1'
+
+  disable_ddl_transaction!
+
+  TABLE_NAME = :board_user_preferences
+  INDEX_NAME = :index_board_user_preferences_on_user_id
+  COLUMN_NAMES = [:user_id]
+
+  def up
+    remove_concurrent_index_by_name(TABLE_NAME, INDEX_NAME)
+  end
+
+  def down
+    add_concurrent_index(TABLE_NAME, COLUMN_NAMES, name: INDEX_NAME)
+  end
+end

db/schema_migrations/20240605232454

+80db15730765286f501843b6943e89eda3c1126a6d3c08a0689adb00a3313ec7
\ No newline at end of file

db/structure.sql

@@ -25324,8 +25324,6 @@ CREATE UNIQUE INDEX index_board_project_recent_visits_on_user_project_and_board
 CREATE INDEX index_board_user_preferences_on_board_id ON board_user_preferences USING btree (board_id);
-CREATE INDEX index_board_user_preferences_on_user_id ON board_user_preferences USING btree (user_id);
-
 CREATE UNIQUE INDEX index_board_user_preferences_on_user_id_and_board_id ON board_user_preferences USING btree (user_id, board_id);
 CREATE INDEX index_boards_epic_board_labels_on_epic_board_id ON boards_epic_board_labels USING btree (epic_board_id);

spec/support/helpers/database/duplicate_indexes.yml

 ---
-board_user_preferences:
-  index_board_user_preferences_on_user_id_and_board_id:
-  - index_board_user_preferences_on_user_id
 boards_epic_board_recent_visits:
   index_epic_board_recent_visits_on_user_group_and_board:
   - index_boards_epic_board_recent_visits_on_user_id