Merge branch 'sh-fix-stale-prometrics-config' into 'master'

Fix stale Prometheus metrics directory not being restored

See merge request gitlab-org/gitlab!76477

spec/metrics_server/metrics_server_spec.rb

@@ -32,6 +32,7 @@
     let(:prometheus_config) { ::Prometheus::Client::Configuration.new }
     let(:metrics_dir) { Dir.mktmpdir }
     let(:settings_double) { double(:settings, sidekiq_exporter: {}) }
+    let!(:old_metrics_dir) { ::Prometheus::Client.configuration.multiprocess_files_dir }
 
     subject(:metrics_server) { described_class.new('fake', metrics_dir, true)}
 
@@ -43,8 +44,11 @@
     end
 
     after do
+      Gitlab::Metrics.reset_registry!
+
       ::Prometheus::CleanupMultiprocDirService.new.execute
       Dir.rmdir(metrics_dir)
+      ::Prometheus::Client.configuration.multiprocess_files_dir = old_metrics_dir
     end
 
     it 'configures ::Prometheus::Client' do