Merge branch '369268-rubocop-reneable-Style/IfInsideElse' into 'master'

RuboCop: Enable previously disabled Style/IfInsideElse

See merge request gitlab-org/gitlab!94117

.haml-lint.yml

@@ -131,6 +131,7 @@ linters:
       - Style/ConditionalAssignment
       - Style/FormatString
       - Style/HashSyntax
+      - Style/IfInsideElse
       - Style/IdenticalConditionalBranches
       - Style/NegatedIf
       - Style/NestedTernaryOperator

.rubocop_todo/style/if_inside_else.yml

 ---
 Style/IfInsideElse:
-  # Offense count: 43
-  # Temporarily disabled due to too many offenses
-  Enabled: false
   Exclude:
     - 'app/controllers/application_controller.rb'
     - 'app/controllers/passwords_controller.rb'
     - 'app/finders/projects_finder.rb'
-    - 'app/finders/user_recent_events_finder.rb'
     - 'app/helpers/diff_helper.rb'
+    - 'app/helpers/issuables_helper.rb'
     - 'app/helpers/members_helper.rb'
     - 'app/helpers/search_helper.rb'
-    - 'app/models/ci/build.rb'
     - 'app/models/namespace.rb'
     - 'app/presenters/project_presenter.rb'
     - 'app/services/system_notes/commit_service.rb'
@@ -22,6 +18,7 @@ Style/IfInsideElse:
     - 'ee/app/controllers/ee/registrations/welcome_controller.rb'
     - 'ee/app/controllers/groups/omniauth_callbacks_controller.rb'
     - 'ee/app/models/ee/namespace.rb'
+    - 'ee/app/models/iterations/cadence.rb'
     - 'ee/app/models/protected_environments/authorizable.rb'
     - 'ee/app/policies/ee/group_policy.rb'
     - 'ee/app/services/app_sec/dast/site_profiles/audit/update_service.rb'
@@ -30,12 +27,15 @@ Style/IfInsideElse:
     - 'ee/app/services/geo/repository_base_sync_service.rb'
     - 'ee/app/services/gitlab_subscriptions/fetch_subscription_plans_service.rb'
     - 'ee/app/services/vulnerability_external_issue_links/create_service.rb'
+    - 'ee/app/workers/elastic/project_transfer_worker.rb'
+    - 'ee/app/workers/project_import_schedule_worker.rb'
     - 'ee/lib/gitlab/geo/base_batcher.rb'
     - 'lib/api/projects.rb'
     - 'lib/gitlab/auth.rb'
     - 'lib/gitlab/conflict/file.rb'
     - 'lib/gitlab/sql/pattern.rb'
     - 'lib/gitlab/usage/service_ping/payload_keys_processor.rb'
+    - 'lib/service_ping/build_payload.rb'
     - 'lib/tasks/gitlab/cleanup.rake'
     - 'lib/tasks/gitlab/shell.rake'
     - 'qa/qa/resource/protected_branch.rb'