Skip to content
GitLab
菜单
为什么选择 GitLab
定价
联系销售
探索
为什么选择 GitLab
定价
联系销售
探索
登录
获取免费试用
主导航
搜索或转到…
项目
GitLab
管理
动态
成员
标记
计划
议题
议题看板
里程碑
迭代
需求
代码
合并请求
仓库
分支
提交
标签
仓库图
比较修订版本
代码片段
锁定的文件
构建
流水线
作业
流水线计划
测试用例
产物
部署
发布
Package registry
Container registry
模型注册表
运维
环境
Terraform 模块
监控
事件
服务台
分析
价值流分析
贡献者分析
CI/CD 分析
仓库分析
代码评审分析
议题分析
洞察
模型实验
效能分析
帮助
帮助
支持
GitLab 文档
比较 GitLab 各版本
社区论坛
为极狐GitLab 提交贡献
提交反馈
隐私声明
快捷键
?
新增功能
4
代码片段
群组
项目
显示更多面包屑
gitlab-cn
GitLab
提交
f1a7724d
未验证
提交
f1a7724d
编辑于
1 year ago
作者:
Rajendra Kadam
提交者:
GitLab
1 year ago
浏览文件
操作
下载
补丁
差异文件
Track catalog release service execution time
上级
29eb3dfa
No related branches found
No related tags found
无相关合并请求
变更
2
隐藏空白变更内容
行内
左右并排
显示
2 个更改的文件
app/services/ci/catalog/resources/release_service.rb
+18
-2
18 个添加, 2 个删除
app/services/ci/catalog/resources/release_service.rb
spec/services/ci/catalog/resources/release_service_spec.rb
+25
-0
25 个添加, 0 个删除
spec/services/ci/catalog/resources/release_service_spec.rb
有
43 个添加
和
2 个删除
app/services/ci/catalog/resources/release_service.rb
+
18
−
2
浏览文件 @
f1a7724d
...
@@ -11,8 +11,10 @@ def initialize(release)
...
@@ -11,8 +11,10 @@ def initialize(release)
end
end
def
execute
def
execute
validate_catalog_resource
track_release_duration
do
create_version
validate_catalog_resource
create_version
end
if
errors
.
empty?
if
errors
.
empty?
ServiceResponse
.
success
ServiceResponse
.
success
...
@@ -25,6 +27,20 @@ def execute
...
@@ -25,6 +27,20 @@ def execute
attr_reader
:project
,
:errors
,
:release
attr_reader
:project
,
:errors
,
:release
def
track_release_duration
name
=
:gitlab_ci_catalog_release_duration_seconds
comment
=
'CI Catalog Release duration'
buckets
=
[
0.01
,
0.05
,
0.1
,
0.5
,
1.0
,
2.0
,
5.0
,
10.0
,
20.0
,
50.0
,
240.0
]
histogram
=
::
Gitlab
::
Metrics
.
histogram
(
name
,
comment
,
{},
buckets
)
start_time
=
::
Gitlab
::
Metrics
::
System
.
monotonic_time
yield
duration
=
::
Gitlab
::
Metrics
::
System
.
monotonic_time
-
start_time
histogram
.
observe
({},
duration
.
seconds
)
end
def
validate_catalog_resource
def
validate_catalog_resource
response
=
Ci
::
Catalog
::
Resources
::
ValidateService
.
new
(
project
,
release
.
sha
).
execute
response
=
Ci
::
Catalog
::
Resources
::
ValidateService
.
new
(
project
,
release
.
sha
).
execute
return
if
response
.
success?
return
if
response
.
success?
...
...
此差异已折叠。
点击以展开。
spec/services/ci/catalog/resources/release_service_spec.rb
+
25
−
0
浏览文件 @
f1a7724d
...
@@ -4,6 +4,31 @@
...
@@ -4,6 +4,31 @@
RSpec
.
describe
Ci
::
Catalog
::
Resources
::
ReleaseService
,
feature_category: :pipeline_composition
do
RSpec
.
describe
Ci
::
Catalog
::
Resources
::
ReleaseService
,
feature_category: :pipeline_composition
do
describe
'#execute'
do
describe
'#execute'
do
context
'when executing release service'
do
let
(
:histogram
)
{
instance_double
(
Prometheus
::
Client
::
Histogram
)
}
before
do
allow
(
Gitlab
::
Metrics
).
to
receive
(
:histogram
).
and_call_original
allow
(
::
Gitlab
::
Metrics
).
to
receive
(
:histogram
).
with
(
:gitlab_ci_catalog_release_duration_seconds
,
'CI Catalog Release duration'
,
{},
[
0.01
,
0.05
,
0.1
,
0.5
,
1.0
,
2.0
,
5.0
,
10.0
,
20.0
,
50.0
,
240.0
]
).
and_return
(
histogram
)
allow
(
::
Gitlab
::
Metrics
::
System
).
to
receive
(
:monotonic_time
).
and_call_original
end
it
'tracks release duration'
do
project
=
create
(
:project
,
:catalog_resource_with_components
)
release
=
create
(
:release
,
project:
project
,
sha:
project
.
repository
.
root_ref_sha
)
expect
(
histogram
).
to
receive
(
:observe
).
with
({},
an_instance_of
(
Float
))
described_class
.
new
(
release
).
execute
end
end
context
'with a valid catalog resource and release'
do
context
'with a valid catalog resource and release'
do
it
'validates the catalog resource and creates a version'
do
it
'validates the catalog resource and creates a version'
do
project
=
create
(
:project
,
:catalog_resource_with_components
)
project
=
create
(
:project
,
:catalog_resource_with_components
)
...
...
此差异已折叠。
点击以展开。
预览
0%
加载中
请重试
或
添加新附件
.
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
保存评论
取消
想要评论请
注册
或
登录