Merge branch 'update-copy-button-feature-flag' into 'master'

Update feature flag for moving copy path button

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/181286



Merged-by: Jacques Erasmus <jerasmus@gitlab.com>
Approved-by: Nataliia Radina <nradina@gitlab.com>
Approved-by: Jacques Erasmus <jerasmus@gitlab.com>
Reviewed-by: Jacques Erasmus <jerasmus@gitlab.com>
Co-authored-by: Chaoyue Zhao <czhao@gitlab.com>

app/assets/javascripts/blob/components/blob_header_filepath.vue

@@ -74,7 +74,7 @@ export default {
     </template>
 
     <clipboard-button
-      v-if="!glFeatures.blobOverflowMenu"
+      v-if="!glFeatures.directoryCodeDropdownUpdates"
       :text="blob.path"
       :gfm="gfmCopyText"
       :title="__('Copy file path')"

app/assets/javascripts/repository/components/header_area/breadcrumbs.vue

@@ -325,7 +325,7 @@ export default {
 
 <template>
   <nav
-    v-if="!glFeatures.blobOverflowMenu"
+    v-if="!glFeatures.directoryCodeDropdownUpdates"
     :aria-label="__('Files breadcrumb')"
     :data-current-path="currentDirectoryPath"
     class="js-repo-breadcrumbs gl-flex"
@@ -368,7 +368,7 @@ export default {
       :path="newDirectoryPath"
     />
   </nav>
-  <div v-else class="gl-flex gl-w-full gl-justify-between sm:gl-w-auto">
+  <div v-else class="repo-breadcrumb gl-flex gl-w-full gl-justify-between sm:gl-w-auto">
     <gl-breadcrumb
       :items="crumbs"
       :data-current-path="currentDirectoryPath"

spec/features/projects/files/project_owner_creates_license_file_spec.rb

@@ -7,7 +7,6 @@
   let_it_be(:project) { create(:project, :repository, namespace: project_maintainer.namespace) }
 
   before do
-    stub_feature_flags(blob_overflow_menu: false)
     project.repository.delete_file(project_maintainer, 'LICENSE',
       message: 'Remove LICENSE', branch_name: 'master')
     sign_in(project_maintainer)

spec/features/projects/files/user_creates_directory_spec.rb

@@ -14,7 +14,6 @@
   let(:user) { create(:user) }
 
   before do
-    stub_feature_flags(blob_overflow_menu: false)
     project.add_developer(user)
     sign_in(user)
     visit project_tree_path(project, 'master')

spec/features/projects/files/user_creates_files_spec.rb

@@ -18,7 +18,6 @@
   let(:user) { create(:user) }
 
   before do
-    stub_feature_flags(blob_overflow_menu: false)
     project.add_maintainer(user)
     sign_in(user)
   end

spec/features/projects/files/user_uploads_files_spec.rb

@@ -8,7 +8,6 @@
   let(:project2) { create(:project, :repository, name: 'Another Project', path: 'another-project') }
 
   before do
-    stub_feature_flags(blob_overflow_menu: false)
     project.add_maintainer(user)
     sign_in(user)
   end

spec/features/projects/show/user_uploads_files_spec.rb

@@ -10,7 +10,6 @@
   let(:project2) { create(:project, :repository, name: 'Another Project', path: 'another-project') }
 
   before do
-    stub_feature_flags(blob_overflow_menu: false)
     project.add_maintainer(user)
     sign_in(user)
   end

spec/frontend/blob/components/blob_header_filepath_spec.js

@@ -42,7 +42,10 @@ describe('Blob Header Filepath', () => {
         ${'renders button that copies path of the blob'} | ${false}
         ${'does not render button'}                      | ${true}
       `('when flag is $flagValue, $description', ({ flagValue }) => {
-        createComponent({}, { provide: { glFeatures: { blobOverflowMenu: flagValue } } });
+        createComponent(
+          {},
+          { provide: { glFeatures: { directoryCodeDropdownUpdates: flagValue } } },
+        );
         const btn = wrapper.findComponent(ClipboardButton);
         expect(btn.exists()).toBe(!flagValue);
         if (!flagValue) {

spec/frontend/repository/components/header_area/breadcrumbs_spec.js

@@ -50,7 +50,7 @@ describe('Repository breadcrumbs component', () => {
     currentPath,
     extraProps = {},
     mockRoute = {},
-    glFeatures = { blobOverflowMenu: false },
+    glFeatures = { directoryCodeDropdownUpdates: false },
   } = {}) => {
     const apolloProvider = createApolloProvider([[permissionsQuery, permissionsQuerySpy]]);
 
@@ -100,13 +100,13 @@ describe('Repository breadcrumbs component', () => {
   describe('permissions queries', () => {
     it.each`
       featureFlag | description
-      ${true}     | ${'when blobOverflowMenu feature flag is enabled'}
-      ${false}    | ${'when blobOverflowMenu feature flag is disabled'}
+      ${true}     | ${'when directoryCodeDropdownUpdates feature flag is enabled'}
+      ${false}    | ${'when directoryCodeDropdownUpdates feature flag is disabled'}
     `('queries for permissions $description', async ({ featureFlag }) => {
       factory({
         currentPath: '/',
         glFeatures: {
-          blobOverflowMenu: featureFlag,
+          directoryCodeDropdownUpdates: featureFlag,
         },
       });
 
@@ -120,8 +120,8 @@ describe('Repository breadcrumbs component', () => {
 
     it.each`
       featureFlag | description
-      ${true}     | ${'when blobOverflowMenu feature flag is enabled'}
-      ${false}    | ${'when blobOverflowMenu feature flag is disabled'}
+      ${true}     | ${'when directoryCodeDropdownUpdates feature flag is enabled'}
+      ${false}    | ${'when directoryCodeDropdownUpdates feature flag is disabled'}
     `('queries for permissions $description', async ({ featureFlag }) => {
       const mockError = new Error('timeout of 0ms exceeded');
       permissionsQuerySpy = jest.fn().mockRejectedValue(mockError);
@@ -129,7 +129,7 @@ describe('Repository breadcrumbs component', () => {
       factory({
         currentPath: '/',
         glFeatures: {
-          blobOverflowMenu: featureFlag,
+          directoryCodeDropdownUpdates: featureFlag,
         },
       });
 
@@ -143,11 +143,11 @@ describe('Repository breadcrumbs component', () => {
     });
   });
 
-  describe('when `blobOverflowMenu` feature flag is enabled', () => {
+  describe('when `directoryCodeDropdownUpdates` feature flag is enabled', () => {
     beforeEach(() => {
       factory({
         glFeatures: {
-          blobOverflowMenu: true,
+          directoryCodeDropdownUpdates: true,
         },
       });
     });
@@ -175,7 +175,7 @@ describe('Repository breadcrumbs component', () => {
       factory({
         currentPath: path,
         glFeatures: {
-          blobOverflowMenu: true,
+          directoryCodeDropdownUpdates: true,
         },
       });
       expect(findGLBreadcrumb().props('items').length).toEqual(linkCount);
@@ -195,7 +195,7 @@ describe('Repository breadcrumbs component', () => {
             name: routeName,
           },
           glFeatures: {
-            blobOverflowMenu: true,
+            directoryCodeDropdownUpdates: true,
           },
         });
 
@@ -214,7 +214,7 @@ describe('Repository breadcrumbs component', () => {
           factory({
             currentPath,
             glFeatures: {
-              blobOverflowMenu: true,
+              directoryCodeDropdownUpdates: true,
             },
           });
           expect(findClipboardButton().exists()).toBe(expected);
@@ -226,7 +226,7 @@ describe('Repository breadcrumbs component', () => {
     });
   });
 
-  describe('when `blobOverflowMenu` feature flag is disabled', () => {
+  describe('when `directoryCodeDropdownUpdates` feature flag is disabled', () => {
     it.each`
       path                        | linkCount
       ${'/'}                      | ${1}
@@ -354,7 +354,7 @@ describe('Repository breadcrumbs component', () => {
           factory({
             currentPath,
             glFeatures: {
-              blobOverflowMenu: flagValue,
+              directoryCodeDropdownUpdates: flagValue,
             },
           });
           expect(findClipboardButton().exists()).toBe(expected);