Use reason instead of http_status

.rubocop_todo/gitlab/service_response.yml

@@ -30,7 +30,6 @@ Gitlab/ServiceResponse:
     - 'app/services/snippets/base_service.rb'
     - 'app/services/snippets/bulk_destroy_service.rb'
     - 'app/services/snippets/destroy_service.rb'
-    - 'app/services/snippets/repository_validation_service.rb'
     - 'app/services/timelogs/base_service.rb'
     - 'app/services/work_items/create_and_link_service.rb'
     - 'app/services/work_items/create_from_task_service.rb'

app/services/snippets/repository_validation_service.rb

@@ -2,6 +2,8 @@
 
 module Snippets
   class RepositoryValidationService
+    INVALID_REPOSITORY = :invalid_snippet_repository
+
     attr_reader :current_user, :snippet, :repository
 
     RepositoryValidationError = Class.new(StandardError)
@@ -25,7 +27,7 @@ def execute
 
       ServiceResponse.success(message: 'Valid snippet repository.')
     rescue RepositoryValidationError => e
-      ServiceResponse.error(message: "Error: #{e.message}", http_status: 400)
+      ServiceResponse.error(message: "Error: #{e.message}", reason: INVALID_REPOSITORY)
     end
 
     private

spec/services/snippets/repository_validation_service_spec.rb

@@ -22,6 +22,7 @@
       allow(repository).to receive(:branch_count).and_return(2)
 
       expect(subject).to be_error
+      expect(subject.reason).to eq(described_class::INVALID_REPOSITORY)
       expect(subject.message).to match(/Repository has more than one branch/)
     end
 
@@ -29,6 +30,7 @@
       allow(repository).to receive(:branch_names).and_return(['foo'])
 
       expect(subject).to be_error
+      expect(subject.reason).to eq(described_class::INVALID_REPOSITORY)
       expect(subject.message).to match(/Repository has an invalid default branch name/)
     end
 
@@ -36,6 +38,7 @@
       allow(repository).to receive(:tag_count).and_return(1)
 
       expect(subject).to be_error
+      expect(subject.reason).to eq(described_class::INVALID_REPOSITORY)
       expect(subject.message).to match(/Repository has tags/)
     end
 
@@ -45,6 +48,7 @@
       allow(repository).to receive(:ls_files).and_return(files)
 
       expect(subject).to be_error
+      expect(subject.reason).to eq(described_class::INVALID_REPOSITORY)
       expect(subject.message).to match(/Repository files count over the limit/)
     end
 
@@ -52,6 +56,7 @@
       allow(repository).to receive(:ls_files).and_return([])
 
       expect(subject).to be_error
+      expect(subject.reason).to eq(described_class::INVALID_REPOSITORY)
       expect(subject.message).to match(/Repository must contain at least 1 file/)
     end
 
@@ -61,6 +66,7 @@
       end
 
       expect(subject).to be_error
+      expect(subject.reason).to eq(described_class::INVALID_REPOSITORY)
       expect(subject.message).to match(/Repository size is above the limit/)
     end