Don't run `update-tests-metadata` if needed jobs failed

If we run it when needed jobs failed, we can be missing metadata from
those failed jobs.

.gitlab/ci/rules.gitlab-ci.yml

@@ -3003,7 +3003,6 @@
     - <<: *if-not-ee
       when: never
     - <<: *if-dot-com-ee-schedule-default-branch-maintenance
-      when: always
     - <<: *if-default-branch-refs
       changes:
         - ".gitlab/ci/test-metadata.gitlab-ci.yml"