Add and backfill project_id for scan_result_policies
## What does this MR do and why? Add and backfill project_id for scan_result_policies. This table has a [desired sharding key](https://docs.gitlab.com/ee/development/database/multiple_databases.html#define-a-desired_sharding_key-to-automatically-backfill-a-sharding_key) configured ([view configuration](https://gitlab.com/gitlab-org/gitlab/-/blob/master/db/docs/scan_result_policies.yml)). This merge request is the first step towards transforming the desired sharding key into a [sharding key](https://docs.gitlab.com/ee/development/database/multiple_databases.html#defining-a-sharding-key-for-all-cell-local-tables). This involves three changes: - Adding a new column that will serve as the sharding key (along with the relevant index and foreign key). - Populating the sharding key when new records are created by adding a database function and trigger. - Scheduling a [batched background migration](https://docs.gitlab.com/ee/development/database/batched_background_migrations.html) to set the sharding key for existing records. Once the background migration has completed, a second merge request will be created to finalize the background migration and validate the not null constraint. ## How to verify We have assigned a random backend engineer from ~"group::security policies" to review these changes. Please review this merge request from a ~backend perspective. The main thing we are looking to verify is that the added column and association match the values specified by the [desired sharding key](https://gitlab.com/gitlab-org/gitlab/-/blob/master/db/docs/scan_result_policies.yml) configuration and that backfilling the column from this other table makes sense in the context of this feature. When you are finished, please: 1. Trigger the [database testing pipeline](https://docs.gitlab.com/ee/development/database/database_migration_pipeline.html) as instructed by Danger. 1. Request a review from the ~backend maintainer and ~database reviewer suggested by Danger. If you have any questions or concerns, reach out to `@tigerwnz` or @shubhamkrai. This merge request was generated by a once off keep implemented in https://gitlab.com/gitlab-org/gitlab/-/merge_requests/143774 This change was generated by [gitlab-housekeeper](https://gitlab.com/gitlab-org/gitlab/-/tree/master/gems/gitlab-housekeeper) using the Keeps::BackfillDesiredShardingKeySmallTable keep. To provide feedback on your experience with `gitlab-housekeeper` please create an issue with the label ~"GitLab Housekeeper" and consider pinging the author of this keep. Changelog: other
上级
a5d076c0
No related branches found
No related tags found
显示
- db/docs/batched_background_migrations/backfill_scan_result_policies_namespace_id.yml 8 个添加, 0 个删除...migrations/backfill_scan_result_policies_namespace_id.yml
- db/docs/batched_background_migrations/backfill_scan_result_policies_project_id.yml 8 个添加, 0 个删除...d_migrations/backfill_scan_result_policies_project_id.yml
- db/docs/scan_result_policies.yml 3 个添加, 0 个删除db/docs/scan_result_policies.yml
- db/migrate/20250301125854_add_namespace_id_to_scan_result_policies.rb 9 个添加, 0 个删除...0250301125854_add_namespace_id_to_scan_result_policies.rb
- db/post_migrate/20250301125533_add_scan_result_policies_project_id_trigger.rb 25 个添加, 0 个删除...0301125533_add_scan_result_policies_project_id_trigger.rb
- db/post_migrate/20250301125534_queue_backfill_scan_result_policies_project_id.rb 40 个添加, 0 个删除...1125534_queue_backfill_scan_result_policies_project_id.rb
- db/post_migrate/20250301125855_index_scan_result_policies_on_namespace_id.rb 16 个添加, 0 个删除...50301125855_index_scan_result_policies_on_namespace_id.rb
- db/post_migrate/20250301125856_add_scan_result_policies_namespace_id_fk.rb 16 个添加, 0 个删除...0250301125856_add_scan_result_policies_namespace_id_fk.rb
- db/post_migrate/20250301125857_add_scan_result_policies_namespace_id_trigger.rb 25 个添加, 0 个删除...01125857_add_scan_result_policies_namespace_id_trigger.rb
- db/post_migrate/20250301125858_queue_backfill_scan_result_policies_namespace_id.rb 40 个添加, 0 个删除...25858_queue_backfill_scan_result_policies_namespace_id.rb
- db/schema_migrations/20250301125533 1 个添加, 0 个删除db/schema_migrations/20250301125533
- db/schema_migrations/20250301125534 1 个添加, 0 个删除db/schema_migrations/20250301125534
- db/schema_migrations/20250301125854 1 个添加, 0 个删除db/schema_migrations/20250301125854
- db/schema_migrations/20250301125855 1 个添加, 0 个删除db/schema_migrations/20250301125855
- db/schema_migrations/20250301125856 1 个添加, 0 个删除db/schema_migrations/20250301125856
- db/schema_migrations/20250301125857 1 个添加, 0 个删除db/schema_migrations/20250301125857
- db/schema_migrations/20250301125858 1 个添加, 0 个删除db/schema_migrations/20250301125858
- db/structure.sql 42 个添加, 0 个删除db/structure.sql
- lib/gitlab/background_migration/backfill_scan_result_policies_namespace_id.rb 10 个添加, 0 个删除...d_migration/backfill_scan_result_policies_namespace_id.rb
- lib/gitlab/background_migration/backfill_scan_result_policies_project_id.rb 10 个添加, 0 个删除...und_migration/backfill_scan_result_policies_project_id.rb
加载中
想要评论请 注册 或 登录