Replace group_custom_roles feature-check with gitlab_com_subscription?
- SubscriptionHelper has a method, gitlab_com_subscription? to check if the application is in SaaS mode, which means we can replace the Gitlab::Saas.feature_available?(:group_custom_roles) check we have when creating/fetching member roles with that method
显示
- ee/app/finders/member_roles/roles_finder.rb 3 个添加, 5 个删除ee/app/finders/member_roles/roles_finder.rb
- ee/app/graphql/mutations/member_roles/create.rb 4 个添加, 7 个删除ee/app/graphql/mutations/member_roles/create.rb
- ee/app/helpers/member_roles_helper.rb 1 个添加, 1 个删除ee/app/helpers/member_roles_helper.rb
- ee/app/models/members/member_role.rb 3 个添加, 5 个删除ee/app/models/members/member_role.rb
- ee/app/services/member_roles/create_service.rb 4 个添加, 6 个删除ee/app/services/member_roles/create_service.rb
- ee/config/saas_features/group_custom_roles.yml 0 个添加, 5 个删除ee/config/saas_features/group_custom_roles.yml
- ee/lib/ee/gitlab/saas.rb 0 个添加, 1 个删除ee/lib/ee/gitlab/saas.rb
- ee/spec/features/admin/member_roles_spec.rb 4 个添加, 2 个删除ee/spec/features/admin/member_roles_spec.rb
- ee/spec/features/groups/member_roles_spec.rb 4 个添加, 2 个删除ee/spec/features/groups/member_roles_spec.rb
- ee/spec/finders/member_roles/roles_finder_spec.rb 18 个添加, 2 个删除ee/spec/finders/member_roles/roles_finder_spec.rb
- ee/spec/helpers/member_roles_helper_spec.rb 9 个添加, 1 个删除ee/spec/helpers/member_roles_helper_spec.rb
- ee/spec/models/members/member_role_spec.rb 9 个添加, 1 个删除ee/spec/models/members/member_role_spec.rb
- ee/spec/presenters/member_presenter_spec.rb 0 个添加, 1 个删除ee/spec/presenters/member_presenter_spec.rb
- ee/spec/requests/api/graphql/mutations/member_role/create_member_role_spec.rb 11 个添加, 2 个删除.../graphql/mutations/member_role/create_member_role_spec.rb
加载中
想要评论请 注册 或 登录