Merge branch 'dblessing_remove_domain_verification_sso_redirect_ff' into 'master'

Remove domain verification SSO redirect feature flag

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/134298



Merged-by: Aboobacker MK <akarakath@gitlab.com>
Approved-by: Aboobacker MK <akarakath@gitlab.com>
Co-authored-by: Drew Blessing <drew@gitlab.com>

ee/app/controllers/groups/settings/domain_verification_controller.rb

@@ -131,8 +131,6 @@ def set_domain
       end
 
       def sso_enforcement_redirect
-        return unless Feature.enabled?(:domain_verification_sso_redirect)
-
         enforce = ::Gitlab::Auth::GroupSaml::SsoEnforcer.new(group.saml_provider, user: current_user).access_restricted?
 
         redirect_to sso_group_saml_providers_url(group, { redirect: request.fullpath }) if enforce

ee/config/feature_flags/development/domain_verification_sso_redirect.yml

----
-name: domain_verification_sso_redirect
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/121430
-rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/413075
-milestone: '16.1'
-type: development
-group: group::authentication and authorization
-default_enabled: false

ee/spec/requests/groups/settings/domain_verification_controller_spec.rb

@@ -88,18 +88,6 @@
 
       expect(response).to redirect_to(sso_group_saml_providers_path(group, { redirect: request.fullpath }))
     end
-
-    context 'when the feature is disabled' do
-      before do
-        stub_feature_flags(domain_verification_sso_redirect: false)
-      end
-
-      it 'does not redirect to SSO sign in' do
-        perform_request
-
-        expect(response).not_to redirect_to(sso_group_saml_providers_url(group, { redirect: request.fullpath }))
-      end
-    end
   end
 
   describe 'GET /groups/:group_id/-/settings/domain_verification', :saas do