Merge branch 'fix-search-zoekt-index' into 'master'

Fix Search::Zoekt.index? logic

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/144592



Merged-by: John Mason <9717668-johnmason@users.noreply.gitlab.com>
Approved-by: John Mason <9717668-johnmason@users.noreply.gitlab.com>
Co-authored-by: Dmitry Gruzd <dgruzd@gitlab.com>

ee/app/models/search/zoekt.rb

@@ -23,7 +23,7 @@ def index?(container)
         root_namespace_id = fetch_root_namespace_id(container)
         return false unless root_namespace_id
 
-        ::Search::Zoekt::EnabledNamespace.for_root_namespace_id(root_namespace_id).exists?
+        ::Search::Zoekt::Index.for_root_namespace_id(root_namespace_id).exists?
       end
 
       private

ee/spec/models/search/zoekt_spec.rb

@@ -12,6 +12,11 @@
     create(:zoekt_index, :ready, zoekt_enabled_namespace: enabled_namespace, node: node)
   end
 
+  let_it_be(:unassigned_group) { create(:group) }
+  let_it_be_with_reload(:enabled_namespace_without_index) do
+    create(:zoekt_enabled_namespace, namespace: unassigned_group)
+  end
+
   describe '#fetch_node_id' do
     subject(:fetch_node_id) { described_class.fetch_node_id(container) }
 
@@ -131,7 +136,7 @@
       it { is_expected.to eq(true) }
     end
 
-    context 'when Zoekt::EnabledNamespace not found' do
+    context 'when Zoekt::Index is not found' do
       let(:container) { build(:project) }
 
       it { is_expected.to eq(false) }
@@ -142,5 +147,11 @@
 
       it { expect { index }.to raise_error(ArgumentError) }
     end
+
+    context 'when group is unassigned' do
+      let(:container) { unassigned_group }
+
+      it { is_expected.to eq(false) }
+    end
   end
 end

ee/spec/workers/search/zoekt/default_branch_changed_worker_spec.rb

@@ -5,6 +5,9 @@
 RSpec.describe ::Search::Zoekt::DefaultBranchChangedWorker, feature_category: :global_search do
   let_it_be(:zoekt_enabled_namespace) { create(:zoekt_enabled_namespace) }
   let_it_be(:project) { create(:project, :repository, namespace: zoekt_enabled_namespace.namespace) }
+  let_it_be(:index) do
+    create(:zoekt_index, :ready, zoekt_enabled_namespace: zoekt_enabled_namespace, node: create(:zoekt_node))
+  end
 
   let(:default_branch_changed_event) { Repositories::DefaultBranchChangedEvent.new(data: data) }
   let(:container) { project }