Merge branch '523627-policies-fix-compliance-frameworks' into 'master'

Add check for nullability for compliance framework

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/183665



Merged-by: Alexander Turinske <aturinske@gitlab.com>
Approved-by: Alexander Turinske <aturinske@gitlab.com>
Reviewed-by: Artur Fedorov <afedorov@gitlab.com>
Co-authored-by: Artur Fedorov <afedorov@gitlab.com>

ee/app/assets/javascripts/security_orchestration/components/policy_editor/scope/compliance_framework_dropdown.vue

@@ -43,13 +43,13 @@ export default {
         };
       },
       update(data) {
-        return this.getUniqueFrameworks(data.namespace?.complianceFrameworks.nodes);
+        return this.getUniqueFrameworks(data.namespace?.complianceFrameworks?.nodes);
       },
       result({ data }) {
         this.pageInfo = data?.namespace?.complianceFrameworks?.pageInfo || {};
 
         if (this.selectedButNotLoadedComplianceIds.length > 0) {
-          this.fetchComplianceFramoworksByIds();
+          this.fetchComplianceFrameworksByIds();
         }
       },
       error() {
@@ -179,7 +179,7 @@ export default {
     this.debouncedSearch.cancel();
   },
   methods: {
-    async fetchComplianceFramoworksByIds() {
+    async fetchComplianceFrameworksByIds() {
       try {
         const { data } = await this.$apollo.query({
           query: getComplianceFrameworkQuery,
@@ -190,7 +190,7 @@ export default {
         });
 
         this.complianceFrameworks = this.getUniqueFrameworks(
-          data?.namespace?.complianceFrameworks.nodes,
+          data?.namespace?.complianceFrameworks?.nodes,
         );
       } catch {
         this.emitError();

ee/spec/frontend/security_orchestration/components/policy_editor/scope/compliance_framework_dropdown_spec.js

@@ -360,6 +360,25 @@ describe('ComplianceFrameworkDropdown', () => {
     });
   });
 
+  describe('when query response has no frameworks', () => {
+    it('emits error when query does not return frameworks', async () => {
+      createComponent({
+        handlers: {
+          complianceFrameworks: jest.fn().mockResolvedValue({
+            data: {
+              namespace: {
+                id: 1,
+                name: 'name',
+              },
+            },
+          }),
+        },
+      });
+      await waitForPromises();
+      expect(wrapper.emitted('framework-query-error')).toHaveLength(1);
+    });
+  });
+
   describe('error state', () => {
     it.each`
       showError | variant      | category       | groupErrorAttribute