Skip to content
代码片段 群组 项目
未验证 提交 e0ce1ea0 编辑于 作者: Rémy Coutable's avatar Rémy Coutable 提交者: GitLab
浏览文件

Check validity of added feature flag files only


Signed-off-by: default avatarRémy Coutable <remy@rymai.me>
上级 0067d5a1
No related branches found
No related tags found
无相关合并请求
...@@ -34,12 +34,22 @@ module Tooling ...@@ -34,12 +34,22 @@ module Tooling
@helper = helper @helper = helper
end end
def check_touched_feature_flag_files def check_added_feature_flag_files
touched_feature_flag_files.each do |feature_flag| added_files.each do |feature_flag|
check_feature_flag_yaml(feature_flag) check_feature_flag_yaml(feature_flag)
end end
end end
def check_modified_feature_flag_files
modified_files.each do |feature_flag|
check_default_enabled(feature_flag)
end
end
def feature_flag_file_added?
added_files.any?
end
def feature_flag_file_touched? def feature_flag_file_touched?
touched_feature_flag_files.any? touched_feature_flag_files.any?
end end
...@@ -201,9 +211,10 @@ feature_flag_dangerfile = Tooling::FeatureFlagDangerfile.new( ...@@ -201,9 +211,10 @@ feature_flag_dangerfile = Tooling::FeatureFlagDangerfile.new(
helper: helper helper: helper
) )
feature_flag_dangerfile.check_touched_feature_flag_files feature_flag_dangerfile.check_added_feature_flag_files
feature_flag_dangerfile.check_modified_feature_flag_files
if helper.security_mr? && feature_flag_dangerfile.feature_flag_file_touched? if helper.security_mr? && feature_flag_dangerfile.feature_flag_file_added?
failure("Feature flags are discouraged from security merge requests. Read the [security documentation](https://gitlab.com/gitlab-org/release/docs/-/blob/master/general/security/utilities/feature_flags.md) for details.") failure("Feature flags are discouraged from security merge requests. Read the [security documentation](https://gitlab.com/gitlab-org/release/docs/-/blob/master/general/security/utilities/feature_flags.md) for details.")
end end
......
0% 加载中 .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册