-
- 下载
Merge branch 'services_refactoring1' into 'master'
Services: code style fixes, minor refactoring ## What does this MR do? It contains code style fixes, minor refactoring and also it removes some unnecessary comments. Every comment require a support just like a regular code line and this is why we should avoid using comments everywhere unless it's really helpful. Martin Fowler said "Find comment and refactor the code around it" :) our code is not that bad so let's not spoil it with comments. ## Why was this MR needed? Because GitLab is a live example of awesome code. Let's keep up a good job :) See merge request !5112
显示
- app/services/audit_event_service.rb 1 个添加, 1 个删除app/services/audit_event_service.rb
- app/services/auth/container_registry_authentication_service.rb 2 个添加, 0 个删除...ervices/auth/container_registry_authentication_service.rb
- app/services/create_branch_service.rb 5 个添加, 5 个删除app/services/create_branch_service.rb
- app/services/create_release_service.rb 1 个添加, 3 个删除app/services/create_release_service.rb
- app/services/create_snippet_service.rb 5 个添加, 5 个删除app/services/create_snippet_service.rb
- app/services/create_tag_service.rb 2 个添加, 0 个删除app/services/create_tag_service.rb
- app/services/delete_branch_service.rb 2 个添加, 10 个删除app/services/delete_branch_service.rb
- app/services/delete_tag_service.rb 2 个添加, 7 个删除app/services/delete_tag_service.rb
- app/services/files/base_service.rb 3 个添加, 4 个删除app/services/files/base_service.rb
- app/services/files/create_service.rb 1 个添加, 1 个删除app/services/files/create_service.rb
- app/services/git_tag_push_service.rb 1 个添加, 0 个删除app/services/git_tag_push_service.rb
- app/services/issues/bulk_update_service.rb 1 个添加, 0 个删除app/services/issues/bulk_update_service.rb
- app/services/merge_requests/post_merge_service.rb 1 个添加, 0 个删除app/services/merge_requests/post_merge_service.rb
- app/services/notification_service.rb 2 个添加, 0 个删除app/services/notification_service.rb
- app/services/projects/update_service.rb 2 个添加, 1 个删除app/services/projects/update_service.rb
- app/services/system_note_service.rb 4 个添加, 3 个删除app/services/system_note_service.rb
- app/services/update_release_service.rb 1 个添加, 3 个删除app/services/update_release_service.rb
- app/services/update_snippet_service.rb 1 个添加, 0 个删除app/services/update_snippet_service.rb
加载中
想要评论请 注册 或 登录