Update AddColumnsToWideTables cop

This commit updates our existing cop to prevent adding columns
on large tables.

.rubocop_todo/layout/line_end_string_concatenation_indentation.yml

@@ -451,7 +451,6 @@ Layout/LineEndStringConcatenationIndentation:
     - 'rubocop/cop/graphql/graphql_name_position.rb'
     - 'rubocop/cop/graphql/json_type.rb'
     - 'rubocop/cop/inject_enterprise_edition_module.rb'
-    - 'rubocop/cop/migration/add_columns_to_wide_tables.rb'
     - 'rubocop/cop/migration/add_limit_to_text_columns.rb'
     - 'rubocop/cop/migration/avoid_finalize_background_migration.rb'
     - 'rubocop/cop/migration/background_migrations.rb'

db/migrate/20231017181403_add_generated_to_diff_files.rb

@@ -4,6 +4,6 @@ class AddGeneratedToDiffFiles < Gitlab::Database::Migration[2.1]
   enable_lock_retries!
 
   def change
-    add_column :merge_request_diff_files, :generated, :boolean
+    add_column :merge_request_diff_files, :generated, :boolean # rubocop:disable Migration/PreventAddingColumns -- Legacy migration
   end
 end

db/migrate/20231020074227_add_auto_canceled_by_partition_id_to_p_ci_builds_self_managed.rb

@@ -5,7 +5,9 @@ class AddAutoCanceledByPartitionIdToPCiBuildsSelfManaged < Gitlab::Database::Mig
 
   # rubocop:disable Migration/AddColumnsToWideTables -- partitioning ci_builds table
   def up
+    # rubocop:disable Migration/PreventAddingColumns -- Legacy migration
     add_column :p_ci_builds, :auto_canceled_by_partition_id, :bigint, default: 100, null: false, if_not_exists: true
+    # rubocop:enable Migration/PreventAddingColumns
   end
   # rubocop:enable Migration/AddColumnsToWideTables
 

db/migrate/20231031114050_add_highest_severity_and_vulnerability_count_into_sbom_occurrences.rb

@@ -4,7 +4,9 @@ class AddHighestSeverityAndVulnerabilityCountIntoSbomOccurrences < Gitlab::Datab
   milestone '16.7'
 
   def change
-    add_column :sbom_occurrences, :highest_severity, :smallint, null: true
+    add_column :sbom_occurrences, :highest_severity, :smallint, null: true # rubocop:disable Migration/PreventAddingColumns -- Legacy migration
+    # rubocop:disable Migration/PreventAddingColumns -- Legacy migration
     add_column :sbom_occurrences, :vulnerability_count, :integer, null: false, default: 0
+    # rubocop:enable Migration/PreventAddingColumns
   end
 end

db/migrate/20231114034017_add_project_id_to_merge_request_diffs.rb

@@ -5,6 +5,6 @@ class AddProjectIdToMergeRequestDiffs < Gitlab::Database::Migration[2.2]
   milestone '16.7'
 
   def change
-    add_column :merge_request_diffs, :project_id, :bigint
+    add_column :merge_request_diffs, :project_id, :bigint # rubocop:disable Migration/PreventAddingColumns -- Legacy migration
   end
 end

db/migrate/20231201122830_add_owasp_top_10_to_vulnerability_reads.rb

@@ -5,6 +5,6 @@ class AddOwaspTop10ToVulnerabilityReads < Gitlab::Database::Migration[2.2]
   milestone '16.7'
 
   def change
-    add_column :vulnerability_reads, :owasp_top_10, :integer, limit: 2
+    add_column :vulnerability_reads, :owasp_top_10, :integer, limit: 2 # rubocop:disable Migration/PreventAddingColumns -- Legacy migration
   end
 end

db/migrate/20231221033539_create_sbom_source_packages_table.rb

@@ -13,7 +13,9 @@ class CreateSbomSourcePackagesTable < Gitlab::Database::Migration[2.2]
   # rubocop:disable Migration/PreventIndexCreation -- Legacy migration
   def up
     with_lock_retries do
+      # rubocop:disable Migration/PreventAddingColumns -- Legacy migration
       add_column :sbom_occurrences, :source_package_id, :bigint, if_not_exists: true
+      # rubocop:enable Migration/PreventAddingColumns
     end
 
     create_table :sbom_source_packages, if_not_exists: true do |t|

db/migrate/20240104092321_add_issue_email_participant_id_to_sent_notifications.rb

@@ -4,6 +4,8 @@ class AddIssueEmailParticipantIdToSentNotifications < Gitlab::Database::Migratio
   milestone '16.9'
 
   def change
+    # rubocop:disable Migration/PreventAddingColumns -- Legacy migration
     add_column :sent_notifications, :issue_email_participant_id, :bigint, null: true
+    # rubocop:enable Migration/PreventAddingColumns
   end
 end

db/migrate/20240109145839_add_partition_id_to_pipeline_config.rb

@@ -5,6 +5,8 @@ class AddPartitionIdToPipelineConfig < Gitlab::Database::Migration[2.2]
   enable_lock_retries!
 
   def change
+    # rubocop:disable Migration/PreventAddingColumns -- Legacy migration
     add_column(:ci_pipelines_config, :partition_id, :bigint, default: 100, null: false)
+    # rubocop:enable Migration/PreventAddingColumns
   end
 end

db/migrate/20240110064826_add_color_mode_id_to_users.rb

@@ -9,7 +9,9 @@ class AddColorModeIdToUsers < Gitlab::Database::Migration[2.2]
 
   # rubocop:disable Migration/AddColumnsToWideTables -- consistent with theme_id
   def change
+    # rubocop:disable Migration/PreventAddingColumns -- Legacy migration
     add_column :users, :color_mode_id, :smallint, default: DEFAULT_COLOR_MODE, null: false, if_not_exists: true
+    # rubocop:enable Migration/PreventAddingColumns
   end
   # rubocop:enable Migration/AddColumnsToWideTables
 end

db/migrate/20240129175101_add_archived_and_traversal_ids_columns_to_sbom_occurrences.rb

@@ -4,7 +4,11 @@ class AddArchivedAndTraversalIdsColumnsToSbomOccurrences < Gitlab::Database::Mig
   milestone '16.9'
 
   def change
+    # rubocop:disable Migration/PreventAddingColumns -- Legacy migration
     add_column :sbom_occurrences, :archived, :boolean, default: false, null: false
+    # rubocop:enable Migration/PreventAddingColumns
+    # rubocop:disable Migration/PreventAddingColumns -- Legacy migration
     add_column :sbom_occurrences, :traversal_ids, 'bigint[]', default: [], null: false
+    # rubocop:enable Migration/PreventAddingColumns
   end
 end

db/migrate/20240201111204_add_tmp_epic_id_column_to_issues.rb

@@ -5,7 +5,7 @@ class AddTmpEpicIdColumnToIssues < Gitlab::Database::Migration[2.2]
   disable_ddl_transaction!
 
   def up
-    add_column :issues, :tmp_epic_id, :bigint
+    add_column :issues, :tmp_epic_id, :bigint # rubocop:disable Migration/PreventAddingColumns -- Legacy migration
   end
 
   def down

db/migrate/20240212170304_add_ancestors_column_to_sbom_occurrences.rb

@@ -6,7 +6,9 @@ class AddAncestorsColumnToSbomOccurrences < Gitlab::Database::Migration[2.2]
   enable_lock_retries!
 
   def up
+    # rubocop:disable Migration/PreventAddingColumns -- Legacy migration
     add_column :sbom_occurrences, :ancestors, :jsonb, default: [], null: false
+    # rubocop:enable Migration/PreventAddingColumns
   end
 
   def down

db/migrate/20240214035028_add_first_and_latest_pipeline_id_to_vulnerability_occurrences.rb

@@ -5,7 +5,11 @@ class AddFirstAndLatestPipelineIdToVulnerabilityOccurrences < Gitlab::Database::
   enable_lock_retries!
 
   def change
+    # rubocop:disable Migration/PreventAddingColumns -- Legacy migration
     add_column :vulnerability_occurrences, :initial_pipeline_id, :bigint, null: true
+    # rubocop:enable Migration/PreventAddingColumns
+    # rubocop:disable Migration/PreventAddingColumns -- Legacy migration
     add_column :vulnerability_occurrences, :latest_pipeline_id, :bigint, null: true
+    # rubocop:enable Migration/PreventAddingColumns
   end
 end

db/migrate/20240320110318_add_file_final_path_to_packages_package_files.rb

@@ -6,7 +6,9 @@ class AddFileFinalPathToPackagesPackageFiles < Gitlab::Database::Migration[2.2]
 
   def up
     with_lock_retries do
+      # rubocop:disable Migration/PreventAddingColumns -- Legacy migration
       add_column :packages_package_files, :file_final_path, :text, if_not_exists: true
+      # rubocop:enable Migration/PreventAddingColumns
     end
 
     add_text_limit :packages_package_files, :file_final_path, 1024

db/migrate/20240327114933_add_override_changes_requested_to_merge_request.rb

@@ -6,6 +6,8 @@ class AddOverrideChangesRequestedToMergeRequest < Gitlab::Database::Migration[2.
   milestone '16.11'
 
   def change
+    # rubocop:disable Migration/PreventAddingColumns -- Legacy migration
     add_column :merge_requests, :override_requested_changes, :boolean, default: false, null: false
+    # rubocop:enable Migration/PreventAddingColumns
   end
 end

db/migrate/20240415134942_add_imported_to_notes.rb

@@ -4,6 +4,8 @@ class AddImportedToNotes < Gitlab::Database::Migration[2.2]
   milestone '17.0'
 
   def change
+    # rubocop:disable Migration/PreventAddingColumns -- Legacy migration
     add_column :notes, :imported, :integer, default: 0, null: false, limit: 2
+    # rubocop:enable Migration/PreventAddingColumns
   end
 end

db/migrate/20240415135009_add_imported_to_merge_requests.rb

@@ -4,6 +4,8 @@ class AddImportedToMergeRequests < Gitlab::Database::Migration[2.2]
   milestone '17.0'
 
   def change
+    # rubocop:disable Migration/PreventAddingColumns -- Legacy migration
     add_column :merge_requests, :imported, :integer, default: 0, null: false, limit: 2
+    # rubocop:enable Migration/PreventAddingColumns
   end
 end

db/migrate/20240415135029_add_imported_to_issues.rb

@@ -4,6 +4,8 @@ class AddImportedToIssues < Gitlab::Database::Migration[2.2]
   milestone '17.0'
 
   def change
+    # rubocop:disable Migration/PreventAddingColumns -- Legacy migration
     add_column :issues, :imported, :integer, default: 0, null: false, limit: 2
+    # rubocop:enable Migration/PreventAddingColumns
   end
 end

db/migrate/20240415135110_add_imported_to_events.rb

@@ -4,6 +4,8 @@ class AddImportedToEvents < Gitlab::Database::Migration[2.2]
   milestone '17.0'
 
   def change
+    # rubocop:disable Migration/PreventAddingColumns -- Legacy migration
     add_column :events, :imported, :integer, default: 0, null: false, limit: 2
+    # rubocop:enable Migration/PreventAddingColumns
   end
 end