Skip to content
代码片段 群组 项目
提交 db119bed 编辑于 作者: Rahul Chanila's avatar Rahul Chanila
浏览文件

Handle missing pipeline user name in terraform registry UI

Changelog: fixed
上级 0f3b8c07
No related branches found
No related tags found
无相关合并请求
...@@ -56,7 +56,7 @@ export default { ...@@ -56,7 +56,7 @@ export default {
}, },
computed: { computed: {
hasPipeline() { hasPipeline() {
return Boolean(this.packageEntity.pipeline); return Boolean(this.packageEntity.pipeline?.user?.name);
}, },
hasProjectLink() { hasProjectLink() {
return Boolean(this.packageEntity.project_path); return Boolean(this.packageEntity.project_path);
......
...@@ -62,9 +62,12 @@ exports[`packages_list_row renders 1`] = ` ...@@ -62,9 +62,12 @@ exports[`packages_list_row renders 1`] = `
class="gl-align-items-center gl-display-flex gl-min-h-6" class="gl-align-items-center gl-display-flex gl-min-h-6"
> >
<span> <span>
<gl-sprintf-stub Created
message="Created %{timestamp}" <span
/> title="December 10, 2015 at 12:00:00 AM GMT"
>
4 years ago
</span>
</span> </span>
</div> </div>
</div> </div>
......
import { GlLink } from '@gitlab/ui'; import { GlLink, GlSprintf } from '@gitlab/ui';
import { nextTick } from 'vue'; import { nextTick } from 'vue';
import { shallowMountExtended } from 'helpers/vue_test_utils_helper'; import { shallowMountExtended } from 'helpers/vue_test_utils_helper';
import { createMockDirective, getBinding } from 'helpers/vue_mock_directive'; import { createMockDirective, getBinding } from 'helpers/vue_mock_directive';
...@@ -9,7 +9,7 @@ import PackageTags from '~/packages_and_registries/shared/components/package_tag ...@@ -9,7 +9,7 @@ import PackageTags from '~/packages_and_registries/shared/components/package_tag
import { PACKAGE_ERROR_STATUS } from '~/packages_and_registries/shared/constants'; import { PACKAGE_ERROR_STATUS } from '~/packages_and_registries/shared/constants';
import ListItem from '~/vue_shared/components/registry/list_item.vue'; import ListItem from '~/vue_shared/components/registry/list_item.vue';
import { packageList } from '../mock_data'; import { packageList, npmPackage } from '../mock_data';
describe('packages_list_row', () => { describe('packages_list_row', () => {
let wrapper; let wrapper;
...@@ -40,6 +40,7 @@ describe('packages_list_row', () => { ...@@ -40,6 +40,7 @@ describe('packages_list_row', () => {
stubs: { stubs: {
ListItem, ListItem,
InfrastructureIconAndName, InfrastructureIconAndName,
GlSprintf,
}, },
propsData: { propsData: {
packageLink: 'foo', packageLink: 'foo',
...@@ -96,6 +97,24 @@ describe('packages_list_row', () => { ...@@ -96,6 +97,24 @@ describe('packages_list_row', () => {
}); });
}); });
describe('published by author', () => {
it('shows the text when user is set', () => {
mountComponent({
packageEntity: { ...npmPackage },
});
expect(wrapper.text()).toContain('published by foo');
});
it('is hidden when user is null', () => {
mountComponent({
packageEntity: { ...npmPackage, pipeline: { ...npmPackage.pipeline, user: null } },
});
expect(wrapper.text()).not.toContain('published by');
});
});
describe('deleteAvailable', () => { describe('deleteAvailable', () => {
it('does not show when not set', () => { it('does not show when not set', () => {
mountComponent({ disableDelete: true }); mountComponent({ disableDelete: true });
......
0% 加载中 .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册