Merge branch 'improve-rspec-database-queries' into 'master'

Reduce spec database queries

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/159399



Merged-by: Marcos Rocha <mrocha@gitlab.com>
Approved-by: Serena Fang <sfang@gitlab.com>
Approved-by: Marcos Rocha <mrocha@gitlab.com>
Co-authored-by: Arturo Herrero <arturo.herrero@gmail.com>

ee/spec/lib/elastic/latest/issue_class_proxy_spec.rb

@@ -9,9 +9,9 @@
 
   subject(:proxy) { described_class.new(Issue, use_separate_indices: true) }
 
-  let!(:group) { create(:group) }
-  let!(:project) { create(:project, :public, group: group) }
-  let!(:user) { create(:user, developer_of: project) }
+  let_it_be(:group) { create(:group) }
+  let_it_be_with_reload(:project) { create(:project, :public, group: group) }
+  let_it_be(:user) { create(:user, developer_of: project) }
   let!(:label) { create(:label, project: project) }
   let!(:issue) { create(:labeled_issue, title: 'test', project: project, labels: [label]) }
   let(:query) { 'test' }