Skip to content
代码片段 群组 项目
未验证 提交 d2e4c436 编辑于 作者: Chad Lavimoniere's avatar Chad Lavimoniere 提交者: GitLab
浏览文件

Remove extra gap when 0 roadmap epics have children

When none of the epics shown in a roadmap view have children, remove the
unnecessary gap that is left for the show/hide children toggle button.

Changelog: fixed
EE: true
上级 1421cf8e
No related branches found
No related tags found
无相关合并请求
......@@ -45,6 +45,11 @@ export default {
type: Object,
required: true,
},
epicsHaveChildren: {
type: Boolean,
required: false,
default: false,
},
clientWidth: {
type: Number,
required: false,
......@@ -166,6 +171,7 @@ export default {
>
<epic-item-details
:epic="epic"
:epics-have-children="epicsHaveChildren"
:timeframe-string="timeframeString(epic)"
:child-level="childLevel"
:is-expanded="isExpanded"
......@@ -203,6 +209,7 @@ export default {
</div>
<epic-item-container
v-if="hasChildrenToShow"
:epics-have-children="epicsHaveChildren"
:client-width="clientWidth"
:children="childEpics"
:child-level="childLevel + 1"
......
......@@ -12,6 +12,11 @@ export default {
required: false,
default: 0,
},
epicsHaveChildren: {
type: Boolean,
required: false,
default: false,
},
children: {
type: Array,
required: true,
......@@ -33,6 +38,7 @@ export default {
v-for="child in children"
:key="generateKey(child)"
:epic="child"
:epics-have-children="epicsHaveChildren"
:client-width="clientWidth"
:child-level="childLevel"
/>
......
......@@ -24,6 +24,11 @@ export default {
type: Object,
required: true,
},
epicsHaveChildren: {
type: Boolean,
required: false,
default: false,
},
timeframeString: {
type: String,
required: true,
......@@ -168,7 +173,10 @@ export default {
>
<span ref="expandCollapseInfo">
<gl-button
:class="{ invisible: isExpandIconHidden }"
:class="{
invisible: isExpandIconHidden,
'gl-hidden': !epicsHaveChildren,
}"
:aria-label="expandIconLabel"
category="tertiary"
size="small"
......
......@@ -37,6 +37,11 @@ export default {
type: Boolean,
required: true,
},
epicsHaveChildren: {
type: Boolean,
required: false,
default: false,
},
hasNextPage: {
type: Boolean,
required: true,
......@@ -177,6 +182,7 @@ export default {
ref="epicItems"
:key="generateKey(epic)"
:epic="epic"
:epics-have-children="epicsHaveChildren"
:timeframe="timeframe"
:client-width="clientWidth"
:child-level="0"
......
......@@ -122,6 +122,9 @@ export default {
footerMessageHeight() {
return document.querySelector('.footer-message')?.getBoundingClientRect().height || 0;
},
epicsHaveChildren() {
return this.epics.some((epic) => epic.hasChildren);
},
},
mounted() {
this.$nextTick(() => {
......@@ -172,6 +175,7 @@ export default {
:epics="epics"
:timeframe="timeframe"
:epics-fetch-next-page-in-progress="epicsFetchNextPageInProgress"
:epics-have-children="epicsHaveChildren"
:has-next-page="hasNextPage"
:buffer-size="bufferSize"
@scrolledToEnd="$emit('scrolledToEnd')"
......
0% 加载中 .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册