Optimize maximum user access level lookup in loading of notes
NotesHelper#note_editable? and ProjectTeam#human_max_access currently take about 16% of the load time of an issue page. This MR preloads the maximum access level of users for all notes in issues and merge requests with several queries instead of one per user and caches the result in RequestStore.
显示
- CHANGELOG 1 个添加, 0 个删除CHANGELOG
- app/controllers/projects/issues_controller.rb 3 个添加, 0 个删除app/controllers/projects/issues_controller.rb
- app/controllers/projects/merge_requests_controller.rb 3 个添加, 0 个删除app/controllers/projects/merge_requests_controller.rb
- app/helpers/notes_helper.rb 7 个添加, 8 个删除app/helpers/notes_helper.rb
- app/models/ability.rb 14 个添加, 0 个删除app/models/ability.rb
- app/models/project_team.rb 35 个添加, 11 个删除app/models/project_team.rb
- lib/gitlab/access.rb 1 个添加, 0 个删除lib/gitlab/access.rb
- spec/helpers/notes_helper_spec.rb 31 个添加, 26 个删除spec/helpers/notes_helper_spec.rb
- spec/models/ability_spec.rb 56 个添加, 0 个删除spec/models/ability_spec.rb
- spec/models/project_team_spec.rb 43 个添加, 8 个删除spec/models/project_team_spec.rb
加载中
想要评论请 注册 或 登录