Align UrlValidator to validate_url gem implementation.
Renamed UrlValidator to AddressableUrlValidator to avoid 'url:' naming collision with ActiveModel::Validations::UrlValidator in 'validates' statement. Make use of the options attribute of the parent class ActiveModel::EachValidator. Add more options: allow_nil, allow_blank, message. Renamed 'protocols' option to 'schemes' to match the option naming from UrlValidator.
显示
- app/models/application_setting.rb 4 个添加, 4 个删除app/models/application_setting.rb
- app/models/badge.rb 1 个添加, 1 个删除app/models/badge.rb
- app/models/ci/build_runner_session.rb 1 个添加, 1 个删除app/models/ci/build_runner_session.rb
- app/models/environment.rb 1 个添加, 1 个删除app/models/environment.rb
- app/models/error_tracking/project_error_tracking_setting.rb 1 个添加, 1 个删除app/models/error_tracking/project_error_tracking_setting.rb
- app/models/generic_commit_status.rb 1 个添加, 1 个删除app/models/generic_commit_status.rb
- app/models/project.rb 1 个添加, 1 个删除app/models/project.rb
- app/models/releases/link.rb 1 个添加, 1 个删除app/models/releases/link.rb
- app/models/remote_mirror.rb 1 个添加, 1 个删除app/models/remote_mirror.rb
- app/validators/addressable_url_validator.rb 112 个添加, 0 个删除app/validators/addressable_url_validator.rb
- app/validators/public_url_validator.rb 11 个添加, 8 个删除app/validators/public_url_validator.rb
- changelogs/unreleased/24985-align-urlvalidator-to-validate_url-gem-implementation.yml 5 个添加, 0 个删除...align-urlvalidator-to-validate_url-gem-implementation.yml
- lib/gitlab/import_export/after_export_strategies/web_upload_strategy.rb 1 个添加, 1 个删除...ort_export/after_export_strategies/web_upload_strategy.rb
- lib/gitlab/url_blocker.rb 5 个添加, 5 个删除lib/gitlab/url_blocker.rb
- spec/controllers/projects/mirrors_controller_spec.rb 1 个添加, 1 个删除spec/controllers/projects/mirrors_controller_spec.rb
- spec/lib/gitlab/url_blocker_spec.rb 3 个添加, 3 个删除spec/lib/gitlab/url_blocker_spec.rb
- spec/requests/api/commit_statuses_spec.rb 16 个添加, 1 个删除spec/requests/api/commit_statuses_spec.rb
- spec/support/shared_examples/url_validator_examples.rb 12 个添加, 12 个删除spec/support/shared_examples/url_validator_examples.rb
- spec/validators/addressable_url_validator_spec.rb 110 个添加, 21 个删除spec/validators/addressable_url_validator_spec.rb
- spec/validators/public_url_validator_spec.rb 4 个添加, 4 个删除spec/validators/public_url_validator_spec.rb
加载中
想要评论请 注册 或 登录