Merge branch 'tor/defect/diffs-multiple-tab-spinners' into 'master'

Reduce spinners shown on switching MR tabs 

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/104201



Merged-by: Phil Hughes <me@iamphill.com>
Approved-by: Stanislav Lashmanov <slashmanov@gitlab.com>
Approved-by: Phil Hughes <me@iamphill.com>
Co-authored-by: Thomas Randolph <trandolph@gitlab.com>

app/assets/javascripts/merge_request_tabs.js

@@ -261,6 +261,8 @@ export default class MergeRequestTabs {
   }
 
   tabShown(action, href, shouldScroll = true) {
+    toggleLoader(false);
+
     if (action !== this.currentTab && this.mergeRequestTabs) {
       this.currentTab = action;
 
@@ -477,8 +479,6 @@ export default class MergeRequestTabs {
       return;
     }
 
-    toggleLoader(true);
-
     loadDiffs({
       // We extract pathname for the current Changes tab anchor href
       // some pages like MergeRequestsController#new has query parameters on that anchor
@@ -496,9 +496,6 @@ export default class MergeRequestTabs {
         createAlert({
           message: __('An error occurred while fetching this tab.'),
         });
-      })
-      .finally(() => {
-        toggleLoader(false);
       });
   }