Merge branch 'add-user-factory-helpers' into 'master'

Introduce ROLE_of: user factory helpers

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/149107



Merged-by: Andy Schoenen <asoiron@gitlab.com>
Approved-by: Josianne Hyson <jhyson@gitlab.com>
Approved-by: Andy Schoenen <asoiron@gitlab.com>
Reviewed-by: Josianne Hyson <jhyson@gitlab.com>
Co-authored-by: Pavel Shutsin <pshutsin@gitlab.com>

ee/spec/controllers/projects/integrations/jira/issues_controller_spec.rb

@@ -6,7 +6,7 @@
   include ProjectForksHelper
 
   let_it_be(:project) { create(:project) }
-  let_it_be(:user) { create(:user, developer_projects: [project]) }
+  let_it_be(:user) { create(:user, developer_of: project) }
   let_it_be(:jira) { create(:jira_integration, project: project, issues_enabled: true, project_key: 'TEST', project_keys: ['TEST']) }
 
   before do

ee/spec/controllers/projects/integrations/zentao/issues_controller_spec.rb

@@ -4,7 +4,7 @@
 
 RSpec.describe Projects::Integrations::Zentao::IssuesController, feature_category: :integrations do
   let_it_be(:project) { create(:project) }
-  let_it_be(:user) { create(:user, developer_projects: [project]) }
+  let_it_be(:user) { create(:user, developer_of: project) }
   let_it_be(:zentao_integration) { create(:zentao_integration, project: project) }
 
   before do

ee/spec/factories/incident_management/escalation_rules.rb

@@ -18,7 +18,7 @@
 
     trait :with_user do
       oncall_schedule {}
-      user { association :user, developer_projects: [policy.project] }
+      user { association :user, developer_of: policy.project }
     end
   end
 end

ee/spec/factories/protected_branches.rb

@@ -14,7 +14,7 @@
 
     trait :user_can_merge do
       authorize_user_to_merge do
-        association(:user, maintainer_projects: [project])
+        association(:user, maintainer_of: project)
       end
     end
 
@@ -26,7 +26,7 @@
 
     trait :user_can_push do
       authorize_user_to_push do
-        association(:user, maintainer_projects: [project])
+        association(:user, maintainer_of: project)
       end
     end
 
@@ -50,7 +50,7 @@
 
     trait :user_can_unprotect do
       authorize_user_to_unprotect do
-        association(:user, maintainer_projects: [project])
+        association(:user, maintainer_of: project)
       end
     end
 

ee/spec/features/incidents/user_uploads_metric_images_spec.rb

@@ -5,7 +5,7 @@
 RSpec.describe 'User uploads metrics to incident', :js, feature_category: :incident_management do
   let_it_be(:incident) { create(:incident) }
   let_it_be(:project) { incident.project }
-  let_it_be(:user) { create(:user, developer_projects: [project]) }
+  let_it_be(:user) { create(:user, developer_of: project) }
 
   context 'when feature is available' do
     before do

ee/spec/features/projects/releases/user_views_release_spec.rb

@@ -11,7 +11,7 @@
     group_milestone = create(:milestone, group: group, title: 'group_milestone_1')
     release = create(:release, project: project, milestones: [group_milestone])
 
-    user = create(:user, developer_projects: [project])
+    user = create(:user, developer_of: project)
     sign_in(user)
     visit project_release_path(project, release)
 

ee/spec/finders/ee/clusters/agents_finder_spec.rb

@@ -5,7 +5,7 @@
 RSpec.describe Clusters::AgentsFinder do
   describe '#execute' do
     let_it_be(:project) { create(:project) }
-    let_it_be(:user) { create(:user, maintainer_projects: [project]) }
+    let_it_be(:user) { create(:user, maintainer_of: project) }
     let_it_be(:reporter) { create(:user) }
 
     let(:current_user) { user }

ee/spec/graphql/mutations/app_sec/fuzzing/coverage/corpus/create_spec.rb

@@ -4,7 +4,7 @@
 
 RSpec.describe Mutations::AppSec::Fuzzing::Coverage::Corpus::Create do
   let_it_be(:project) { create(:project) }
-  let_it_be(:developer) { create(:user, developer_projects: [project]) }
+  let_it_be(:developer) { create(:user, developer_of: project) }
   let_it_be(:package) { create(:package, project: project, creator: developer) }
 
   let(:corpus) { AppSec::Fuzzing::Coverage::Corpus.find_by(user: developer, project: project) }

ee/spec/graphql/mutations/dast/profiles/create_spec.rb

@@ -5,7 +5,7 @@
 RSpec.describe Mutations::Dast::Profiles::Create, :dynamic_analysis,
   feature_category: :dynamic_application_security_testing do
   let_it_be(:project) { create(:project, :repository) }
-  let_it_be(:developer) { create(:user, developer_projects: [project]) }
+  let_it_be(:developer) { create(:user, developer_of: project) }
   let_it_be(:dast_site_profile) { create(:dast_site_profile, project: project) }
   let_it_be(:dast_scanner_profile) { create(:dast_scanner_profile, project: project) }
 

ee/spec/graphql/resolvers/app_sec/dast/profile_resolver_spec.rb

@@ -10,7 +10,7 @@
   end
 
   let_it_be(:project) { create(:project) }
-  let_it_be(:developer) { create(:user, developer_projects: [project]) }
+  let_it_be(:developer) { create(:user, developer_of: project) }
   let_it_be(:dast_profile1) { create(:dast_profile, project: project) }
   let_it_be(:dast_profile2) { create(:dast_profile, project: project) }
 

ee/spec/graphql/resolvers/clusters/agents_resolver_spec.rb

@@ -17,7 +17,7 @@
     let_it_be(:project) { create(:project) }
     let(:ctx) { { current_user: current_user } }
     let(:params) { {} }
-    let_it_be(:maintainer) { create(:user, developer_projects: [project]) }
+    let_it_be(:maintainer) { create(:user, developer_of: project) }
     let_it_be(:reporter) { create(:user) }
 
     before do

ee/spec/graphql/resolvers/dast_site_profile_resolver_spec.rb

@@ -10,7 +10,7 @@
   end
 
   let_it_be(:project) { create(:project) }
-  let_it_be(:developer) { create(:user, developer_projects: [project]) }
+  let_it_be(:developer) { create(:user, developer_of: project) }
   let_it_be(:dast_site_profile1) { create(:dast_site_profile, project: project) }
   let_it_be(:dast_site_profile2) { create(:dast_site_profile, project: project) }
   let_it_be(:dast_site_profile3) do

ee/spec/graphql/types/app_sec/fuzzing/coverage/corpus_type_spec.rb

@@ -7,7 +7,7 @@
 
   let_it_be(:project) { create(:project, :repository) }
   let_it_be(:object) { create(:corpus, project: project) }
-  let_it_be(:user) { create(:user, developer_projects: [project]) }
+  let_it_be(:user) { create(:user, developer_of: project) }
   let_it_be(:fields) { %i[id package] }
 
   specify { expect(described_class.graphql_name).to eq('CoverageFuzzingCorpus') }

ee/spec/graphql/types/dast/pre_scan_verification_step_type_spec.rb

@@ -18,7 +18,7 @@
     )
   end
 
-  let_it_be(:user) { create(:user, developer_projects: [project]) }
+  let_it_be(:user) { create(:user, developer_of: project) }
   let_it_be(:fields) { %i[name check_type errors success] }
 
   before do

ee/spec/graphql/types/dast/pre_scan_verification_type_spec.rb

@@ -9,7 +9,7 @@
   let_it_be(:project) { create(:project) }
   let_it_be(:dast_profile) { create(:dast_profile, project: project) }
   let_it_be(:object) { create(:dast_pre_scan_verification, dast_profile: dast_profile) }
-  let_it_be(:user) { create(:user, developer_projects: [project]) }
+  let_it_be(:user) { create(:user, developer_of: project) }
   let_it_be(:dast_pre_scan_verification_step_1) do
     create(
       :dast_pre_scan_verification_step,

ee/spec/graphql/types/dast/profile_schedule_type_spec.rb

@@ -7,7 +7,7 @@
 
   let_it_be(:fields) { %i[id active startsAt timezone nextRunAt cadence ownerValid] }
   let_it_be(:project) { create(:project) }
-  let_it_be(:user) { create(:user, developer_projects: [project]) }
+  let_it_be(:user) { create(:user, developer_of: project) }
   let_it_be(:object) { create(:dast_profile_schedule, project: project, owner: user) }
 
   specify { expect(described_class.graphql_name).to eq('DastProfileSchedule') }

ee/spec/graphql/types/dast/profile_type_spec.rb

@@ -9,7 +9,7 @@
   let_it_be(:project) { create(:project, :repository) }
   let_it_be(:object) { create(:dast_profile, project: project) }
   let_it_be(:dast_pre_scan_verification) { create(:dast_pre_scan_verification, dast_profile: object) }
-  let_it_be(:user) { create(:user, developer_projects: [project]) }
+  let_it_be(:user) { create(:user, developer_of: project) }
   let_it_be(:tag_list) { %w[ruby postgres] }
 
   let_it_be(:fields) do

ee/spec/graphql/types/dast/site_profile_auth_type_spec.rb

@@ -6,7 +6,7 @@
   include GraphqlHelpers
 
   let_it_be(:project) { create(:project) }
-  let_it_be(:user) { create(:user, developer_projects: [project]) }
+  let_it_be(:user) { create(:user, developer_of: project) }
   let_it_be(:object, reload: true) { create(:dast_site_profile, project: project) }
   let_it_be(:fields) { %i[enabled url usernameField passwordField username password submitField] }
 

ee/spec/graphql/types/dast_site_profile_type_spec.rb

@@ -7,7 +7,7 @@
   include RepoHelpers
 
   let_it_be(:project) { create(:project) }
-  let_it_be(:user) { create(:user, developer_projects: [project]) }
+  let_it_be(:user) { create(:user, developer_of: project) }
   let_it_be(:object, reload: true) { create(:dast_site_profile, project: project) }
   let_it_be(:fields) { %i[id profileName targetUrl targetType editPath excludedUrls requestHeaders validationStatus userPermissions normalizedTargetUrl auth referencedInSecurityPolicies scanMethod scanFilePath validationStartedAt] }
 

ee/spec/helpers/ee/branches_helper_spec.rb

@@ -17,7 +17,7 @@
       let!(:project) { create(:project) }
       let!(:protected_branch) { create(:protected_branch, :developers_can_merge, :maintainers_can_push, project: project) }
       let!(:deploy_key) { create(:deploy_key, deploy_keys_projects: [create(:deploy_keys_project, :write_access, project: project)]) }
-      let(:user) { create(:user, maintainer_projects: [project]) }
+      let(:user) { create(:user, maintainer_of: project) }
 
       let(:merge_level) { protected_branch.merge_access_levels.first }
       let(:push_level) { protected_branch.push_access_levels.first }