Merge branch 'ph/fixNewMRDashboardCacheCountInvalidating' into 'master'

Fixes cache count not invalidating for merge request assignees

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/165015



Merged-by: Marcos Rocha <mrocha@gitlab.com>
Approved-by: Sam Figueroa <sfigueroa@gitlab.com>
Approved-by: Marcos Rocha <mrocha@gitlab.com>
Co-authored-by: Phil Hughes <me@iamphill.com>

app/services/merge_requests/base_service.rb

@@ -81,6 +81,7 @@ def handle_reviewers_change(merge_request, old_reviewers)
       notification_service.async.changed_reviewer_of_merge_request(merge_request, current_user, old_reviewers)
       todo_service.reassigned_reviewable(merge_request, current_user, old_reviewers)
       invalidate_cache_counts(merge_request, users: affected_reviewers.compact)
+      invalidate_cache_counts(merge_request, users: merge_request.assignees)
 
       new_reviewers = merge_request.reviewers - old_reviewers
       merge_request_activity_counter.track_users_review_requested(users: new_reviewers)

spec/services/merge_requests/update_service_spec.rb

@@ -693,6 +693,12 @@ def update_merge_request(opts)
           expect(user3.review_requested_open_merge_requests_count).to eq(0)
         end
 
+        it 'invalidates assignee merge request count cache' do
+          expect(merge_request.assignees).to all(receive(:invalidate_merge_request_cache_counts))
+
+          update_merge_request(reviewer_ids: [user2.id])
+        end
+
         it_behaves_like 'triggers GraphQL subscription mergeRequestReviewersUpdated' do
           let(:action) { update_merge_request({ reviewer_ids: [user2.id] }) }
         end