Skip to content
代码片段 群组 项目
未验证 提交 cd84f2a9 编辑于 作者: Joe Woodward's avatar Joe Woodward 提交者: GitLab
浏览文件

Merge branch 'ph/514923/mrApproversFilterHiddenUsersDefaultEnabled' into 'master'

Enable `mr_approvers_filter_hidden_users` by default

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/180592



Merged-by: default avatarJoe Woodward <jwoodward@gitlab.com>
Approved-by: default avatarAmy Qualls <aqualls@gitlab.com>
Approved-by: default avatarJoe Woodward <jwoodward@gitlab.com>
Co-authored-by: default avatarAmy Qualls <aqualls@gitlab.com>
Co-authored-by: default avatarPhil Hughes <me@iamphill.com>
No related branches found
No related tags found
无相关合并请求
...@@ -71,6 +71,8 @@ Use cases include: ...@@ -71,6 +71,8 @@ Use cases include:
## View approval status ## View approval status
> - More granular approver display [introduced](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/178005) in GitLab 17.9 [with a flag](../../../../administration/feature_flags.md) named `mr_approvers_filter_hidden_users`. Enabled by default.
You can see the approval status of a merge request in two places. On the [merge request itself](#for-a-single-merge-request) You can see the approval status of a merge request in two places. On the [merge request itself](#for-a-single-merge-request)
and in the [list of merge requests](#in-the-list-of-merge-requests) for your project or group. and in the [list of merge requests](#in-the-list-of-merge-requests) for your project or group.
...@@ -95,6 +97,14 @@ The widget displays one of these statuses: ...@@ -95,6 +97,14 @@ The widget displays one of these statuses:
To check if your approval satisfies Code Owner requirements, select **Expand eligible approvers** (**{chevron-lg-down}**). To check if your approval satisfies Code Owner requirements, select **Expand eligible approvers** (**{chevron-lg-down}**).
If you have enabled the `mr_approvers_filter_hidden_users` feature flag, introduced in GitLab 17.9,
approver visibility depends on your project membership, and group privacy:
- Project members see all approvers.
- Project non-members see:
- All approvers, if the approvers are all from public groups.
- No information about approvers, if any of the approvers are from private groups.
### In the list of merge requests ### In the list of merge requests
The list of merge requests for [your project or group](../_index.md#view-merge-requests) The list of merge requests for [your project or group](../_index.md#view-merge-requests)
......
...@@ -6,4 +6,4 @@ rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/514923 ...@@ -6,4 +6,4 @@ rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/514923
milestone: '17.9' milestone: '17.9'
group: group::code review group: group::code review
type: beta type: beta
default_enabled: false default_enabled: true
0% 加载中 .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册