Skip to content
代码片段 群组 项目
未验证 提交 c9e7fbb9 编辑于 作者: Stan Hu's avatar Stan Hu
浏览文件

Ensure Workhorse log writers are closed to avoid Goroutine leaks

We've seen in production the number of Goroutines in Workhorse exceed
4000. The pprof output suggests that many of these came from the
logrus Goroutines lingering.

When Workhorse forks `gitlab-zip-cat` and `gitlab-zip-metadata` it
attempts to log all stderr via a logrus Writer. logrus launches a
Goroutine to listen from a pipe. We should ensure this Writer is
closed so that the Goroutines shut down as soon as possible.

Changelog: fixed
上级 6ffc9a77
No related branches found
No related tags found
加载中
加载中
0% 加载中 .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册