Skip to content
代码片段 群组 项目
未验证 提交 c8850f3d 编辑于 作者: Douglas Barbosa Alexandre's avatar Douglas Barbosa Alexandre 提交者: GitLab
浏览文件

Merge branch 'quick-fix-for-codequality-endpoint-status' into 'master'

Add new attribute to check codequality report status

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/139523



Merged-by: default avatarDouglas Barbosa Alexandre <dbalexandre@gmail.com>
Approved-by: default avatarJames Nutt <jnutt@gitlab.com>
Reviewed-by: default avatarJames Nutt <jnutt@gitlab.com>
Co-authored-by: default avatarAhmed Hemdan <ahemdan@gitlab.com>
No related branches found
No related tags found
无相关合并请求
...@@ -25,7 +25,10 @@ def diffs_tab_pane_data(project, merge_request, params) ...@@ -25,7 +25,10 @@ def diffs_tab_pane_data(project, merge_request, params)
show_generate_test_file_button: ::Llm::GenerateTestFileService.new(current_user, merge_request).valid?.to_s show_generate_test_file_button: ::Llm::GenerateTestFileService.new(current_user, merge_request).valid?.to_s
} }
data[:sast_report_available] = merge_request.has_sast_reports?.to_s if ::Feature.enabled?(:sast_reports_in_inline_diff, project) if ::Feature.enabled?(:sast_reports_in_inline_diff, project)
data[:codequality_report_available] = merge_request.has_codequality_reports?.to_s if project.licensed_feature_available?(:inline_codequality)
data[:sast_report_available] = merge_request.has_sast_reports?.to_s
end
super.merge(data) super.merge(data)
end end
......
...@@ -55,6 +55,46 @@ ...@@ -55,6 +55,46 @@
end end
end end
context 'for codequality_report_available' do
context 'when feature is licensed' do
before do
stub_licensed_features(inline_codequality: true)
allow(merge_request).to receive(:has_codequality_reports?).and_return('true')
end
it 'returns expected value' do
expect(subject[:codequality_report_available]).to eq('true')
end
context 'when merge request does not have codequality reports' do
before do
allow(merge_request).to receive(:has_codequality_reports?).and_return('false')
end
it 'returns expected value' do
expect(subject[:codequality_report_available]).to eq('false')
end
end
context 'when feature flag is disabled' do
before do
stub_feature_flags(sast_reports_in_inline_diff: false)
end
it 'does not return the variable' do
expect(subject).not_to have_key(:codequality_report_available)
end
end
end
context 'when feature is not licensed' do
it 'does not return the variable' do
expect(subject).not_to have_key(:codequality_report_available)
end
end
end
context 'for sast_report_available' do context 'for sast_report_available' do
before do before do
allow(merge_request).to receive(:has_sast_reports?).and_return(true) allow(merge_request).to receive(:has_sast_reports?).and_return(true)
......
0% 加载中 .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册