Merge branch 'mc_rocha-add-limits-license-names' into 'master'

Add limits for license names

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/143137



Merged-by: Kerri Miller <kerrizor@kerrizor.com>
Approved-by: Andy Soiron <asoiron@gitlab.com>
Approved-by: Kerri Miller <kerrizor@kerrizor.com>
Co-authored-by: mc_rocha <mrocha@gitlab.com>

ee/app/validators/json_schemas/security_orchestration_policy.json

@@ -660,11 +660,13 @@
                   "type": "array",
                   "description": "Specifies the licenses to match.",
                   "minItems": 1,
+                  "maxItems": 1000,
                   "uniqueItems": true,
                   "additionalItems": false,
                   "items": {
                     "type": "string",
-                    "minLength": 1
+                    "minLength": 1,
+                    "maxLength": 255
                   }
                 },
                 "license_states": {

ee/spec/models/security/orchestration_policy_configuration_spec.rb

@@ -1308,6 +1308,38 @@
             expect(errors).to contain_exactly(
               "property '/#{type}/0/rules/0/license_types/0' is invalid: error_type=minLength")
           end
+
+          context "when too long" do
+            before do
+              rule[:license_types] = ["a" * 256]
+            end
+
+            specify do
+              expect(errors).to contain_exactly("property '/#{type}/0/rules/0/license_types/0' is invalid: error_type=maxLength")
+            end
+          end
+
+          context "with repeated licenses" do
+            before do
+              rule[:license_types] = ["a"] * 2
+            end
+
+            specify do
+              expect(errors).to contain_exactly("property '/#{type}/0/rules/0/license_types' is invalid: error_type=uniqueItems")
+            end
+          end
+
+          context "with too many licenses" do
+            before do
+              licenses = []
+              1001.times { |i| licenses << "License #{i}" }
+              rule[:license_types] = licenses
+            end
+
+            specify do
+              expect(errors).to contain_exactly("property '/#{type}/0/rules/0/license_types' is invalid: error_type=maxItems")
+            end
+          end
         end
 
         describe "license_states" do